controller-patterns
Review and update existing Rails controllers and generate new controllers following professional patterns and best practices. Covers RESTful conventions, authorization patterns, proper error handling, and maintainable code organization.
70
63%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./skills/controller-patterns/SKILL.mdQuality
Discovery
50%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
The description adequately identifies its domain (Rails controllers) and lists relevant concerns but lacks an explicit 'Use when...' clause, which is a significant gap for skill selection. The capabilities listed are more categorical than concrete, and trigger term coverage misses common user phrasings. It's a solid foundation but needs refinement to stand out among potentially many Rails or web development skills.
Suggestions
Add an explicit 'Use when...' clause, e.g., 'Use when the user asks about Rails controllers, creating new controller actions, adding authorization to endpoints, or organizing controller code.'
Include more natural trigger terms and variations users would say, such as 'Ruby on Rails', 'CRUD actions', 'before_action', 'strong parameters', 'controller specs', or 'API endpoints'.
Make capabilities more concrete by specifying actions like 'add before_action callbacks, implement strong parameters, set up Pundit/CanCanCan authorization, structure concerns and service objects'.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Names the domain (Rails controllers) and lists some actions ('review and update', 'generate new controllers'), plus mentions specific concerns like RESTful conventions, authorization patterns, error handling, and code organization. However, these are more categories than concrete actions—it doesn't specify things like 'add before_action callbacks', 'implement strong parameters', or 'set up resource routing'. | 2 / 3 |
Completeness | The 'what' is reasonably covered (review/update/generate Rails controllers with best practices), but there is no explicit 'Use when...' clause or equivalent trigger guidance. The 'when' is only implied by the description of capabilities, which per the rubric caps completeness at 2. | 2 / 3 |
Trigger Term Quality | Includes relevant terms like 'Rails controllers', 'RESTful', 'authorization', and 'error handling' which users might mention. However, it misses common variations like 'Ruby on Rails', 'controller actions', 'CRUD', 'routes', 'params', 'before_action', or file extensions like '.rb'. | 2 / 3 |
Distinctiveness Conflict Risk | Focuses specifically on Rails controllers, which is more specific than generic code help. However, it could overlap with a general Rails skill, a Ruby code review skill, or a broader web framework skill. The mention of 'authorization patterns' and 'error handling' could also conflict with more general skills covering those topics. | 2 / 3 |
Total | 8 / 12 Passed |
Implementation
77%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a highly actionable and well-structured Rails controller skill with excellent executable examples covering CRUD, nested resources, state transitions, and bulk operations. Its main weakness is verbosity through repetition — the same CRUD pattern appears three times (Quick Reference, RESTful Action Patterns, Complete Examples), and the entire content could benefit from splitting advanced patterns into separate files. The decision tree and review checklist are strong additions that enhance workflow clarity.
Suggestions
Eliminate the 'RESTful Action Patterns' section (§3) since it duplicates both the Quick Reference CRUD template and the Complete Examples — keep one canonical version.
Move 'Complete Examples' and 'Advanced Patterns' into separate referenced files (e.g., EXAMPLES.md, ADVANCED_PATTERNS.md) to reduce the main skill's token footprint while preserving discoverability.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill is quite long (~400 lines) with significant repetition. The 'Complete Examples' section largely duplicates the 'Quick Reference' CRUD template and the 'RESTful Action Patterns' section repeats what's already shown. However, the content is mostly pattern-specific and avoids explaining basic Rails concepts Claude would already know. | 2 / 3 |
Actionability | Excellent actionability throughout. Every pattern includes fully executable Ruby code with proper class definitions, method signatures, routes, and view helpers. The strong parameters, authorization, and state controller examples are all copy-paste ready with realistic naming. | 3 / 3 |
Workflow Clarity | The decision tree clearly routes to the correct pattern. The 'Agent Instructions' section provides explicit step-by-step workflows for both generating and reviewing controllers, including a prioritized checklist. State validation patterns include proper guard clauses with early returns, serving as validation checkpoints. | 3 / 3 |
Progressive Disclosure | The content is well-structured with clear sections progressing from quick reference to advanced patterns, but it's monolithic — all content is inline in a single file. Given the length (~400 lines), the advanced patterns (state controllers, bulk operations) and complete examples could be split into referenced files to reduce the token footprint of the main skill. | 2 / 3 |
Total | 10 / 12 Passed |
Validation
90%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 10 / 11 Passed
Validation for skill structure
| Criteria | Description | Result |
|---|---|---|
skill_md_line_count | SKILL.md is long (639 lines); consider splitting into references/ and linking | Warning |
Total | 10 / 11 Passed | |
- Repository
- RoleModel/rolemodel-skills
- Commit
097ad6b
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.