controller-patterns

Review and update existing Rails controllers and generate new controllers following professional patterns and best practices. Covers RESTful conventions, authorization patterns, proper error handling, and maintainable code organization.

Quality

68%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./skills/controller-patterns/SKILL.md

Quality

Content

65%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable — complete, executable Ruby for every pattern plus a decision tree, anti-pattern table, and review checklist — but it is a monolithic 650-line file that duplicates the standard CRUD pattern three times and keeps advanced material inline instead of in reference files. Batch and destructive workflows also lack verification checkpoints on their results.

Suggestions

Deduplicate the standard CRUD pattern: keep the complete controller in one place and remove either the 'Core Patterns at a Glance' code block or the per-action walkthrough in section 3.

Move the Advanced Patterns and Complete Examples into references/ files (e.g. references/advanced-patterns.md, references/examples.md), leaving SKILL.md as an overview with clearly signaled links.

Add result-verification steps to batch and destructive workflows (e.g. compare @entries.count against submitted ids and alert on mismatches, or verify the record reloads in the expected state after update_all).

Dimension	Reasoning	Score
Conciseness	The body is mostly pattern-and-code rather than prose, but the standard CRUD controller is shown essentially three times ("Core Patterns at a Glance", the per-action walkthrough in section 3, and the "Simple CRUD Controller" complete example), and sections on HTTP status codes and flash basics re-explain Rails knowledge Claude already has. It sits between anchor 3 (mostly efficient, could be tightened) and anchor 4 (efficient, minor trim) — the triple duplication pushes it to 3.	3 / 5
Actionability	Every pattern ships copy-paste-ready Ruby: complete controllers, routes (resources... module:), view snippets (button_to, form_with), params.expect strong-parameter shapes, an anti-pattern vs. correct table, and a review checklist. The examples concretely cover the common cases the skill targets.	5 / 5
Workflow Clarity	The decision tree and numbered "Generating New Controllers" steps give a clear sequence, and state/bulk patterns include ensure_* before_action precondition guards. But the skill includes destructive (destroy) and batch operations (bulk submissions using update_all), and there are no validation/verification checkpoints on the outcome of those operations — the judging guideline caps workflow clarity at 3 in that case.	3 / 5
Progressive Disclosure	Sections are well-labeled (Quick Reference, Decision Tree, Essential Patterns, Complete Examples, Advanced Patterns, Agent Instructions), but the ~650-line body inlines advanced patterns and full example controllers that clearly belong in separate reference files; no references/ bundle exists. This matches anchor 3 (some structure, content that should be separate is inline) rather than 4, since nothing is split out at all.	3 / 5
	Total	14 / 20 Passed

Description

58%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description clearly states what the skill does with several concrete actions in a distinct Rails-controller niche, but it completely lacks a "Use when..." trigger clause and misses natural trigger synonyms (notably those already listed in the frontmatter metadata triggers). Adding explicit usage triggers would lift both completeness and trigger-term quality.

Suggestions

Append an explicit trigger clause, e.g. "Use when generating, reviewing, or modifying Rails controllers, adding controller actions, or working with before_action callbacks."

Fold natural trigger terms already present in the metadata triggers (e.g. "controller action", "before_action", "controller callback", "generate controller") into the description itself so they are surfaced at trigger time.

Trim generic filler ("professional patterns and best practices", "maintainable code organization") in favor of concrete capabilities like nested resources, state transitions, and bulk operations.

Dimension	Reasoning	Score
Specificity	"Review and update existing Rails controllers and generate new controllers" lists three concrete actions, and "Covers RESTful conventions, authorization patterns, proper error handling" names specific sub-capabilities. It stops short of anchor 5's comprehensiveness because nested resources, state transitions, and bulk operations — all covered in the body — are not mentioned.	4 / 5
Completeness	The "what" is clearly stated (review, update, and generate Rails controllers with specific pattern areas), but there is no "Use when..." clause or any explicit trigger guidance — the judging guideline caps completeness at 3 when trigger guidance is missing. This matches anchor 3 (clear what, missing when) and not 4, where the "when" is present but could be more specific.	3 / 5
Trigger Term Quality	Relevant keywords like "Rails controllers", "RESTful conventions", and "authorization" are present, but common natural variations users would say (e.g. "scaffold", "controller action", "Pundit", "before_action") are missing from the description itself. Not score 4 because the coverage lacks the synonym breadth of the anchor example.	3 / 5
Distinctiveness Conflict Risk	"Rails controllers" is a clear niche unlikely to trigger unrelated skills, but generic phrases like "professional patterns and best practices" and "maintainable code organization" create minor overlap risk with closely related Rails skills (models, routing, general code review). Not 5 because those broad phrases dilute the distinct niche.	4 / 5
	Total	14 / 20 Passed

Validation

87%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 14 / 16 Passed

Validation for skill structure

Criteria	Description	Result
skill_md_line_count	SKILL.md is long (652 lines); consider splitting into references/ and linking	Warning
metadata_version	'metadata.version' is missing	Warning

	Total	14 / 16 Passed

Repository: RoleModel/rolemodel-skills
Path: skills/controller-patterns/SKILL.md
Commit: cb80143

Reviewed: 6 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.