controller-patterns

Review and update existing Rails controllers and generate new controllers following professional patterns and best practices. Covers RESTful conventions, authorization patterns, proper error handling, and maintainable code organization.

Quality

68%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./skills/controller-patterns/SKILL.md

Quality

Content

65%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable with executable, copy-paste-ready Rails patterns and a useful decision tree, but it is held back by triple-repetition of the CRUD controller, missing validation checkpoints in the generation workflow, and a monolithic structure that would benefit from reference files.

Suggestions

Collapse the repeated CRUD controller: keep one complete example and have the per-action Essential Patterns section reference it or show only the differing fragments, cutting significant tokens.

Add an explicit validation/verification step to the "Generating New Controllers" workflow (e.g. run the test suite, confirm authorization holds for every action) so destructive and batch workflows clear the workflow_clarity cap.

Move Advanced Patterns and/or Complete Examples into separate reference files under ./references/ and link to them from the body to improve progressive disclosure and reduce the inline footprint.

Dimension	Reasoning	Score
Conciseness	Mostly efficient with no over-explanation of basic Rails concepts, but the standard CRUD controller is shown nearly in full three times (Quick Reference, per-action breakdown in Essential Patterns, and Complete Examples), which is padding that could be tightened.	3 / 5
Actionability	Fully executable, copy-paste-ready Ruby code throughout, with complete controllers, routes, and view snippets covering the common cases (CRUD, nested, state, bulk, nested attributes).	5 / 5
Workflow Clarity	A clear decision tree and numbered generation/review steps provide sequence, but the generation workflow lacks validation checkpoints and the skill covers destructive and batch operations, which per the rubric caps workflow_clarity at 3.	3 / 5
Progressive Disclosure	Well-organized into clear sections, but ~650 lines are monolithically inlined with Advanced Patterns and Complete Examples that could live in separate reference files; no bundle files exist to offload detail.	3 / 5
	Total	14 / 20 Passed

Description

71%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific and well-scoped to Rails controllers with good keyword coverage, but it lacks an explicit "Use when..." trigger clause, capping its completeness. Adding a concrete when-to-use phrase would lift it to the top anchor.

Suggestions

Append an explicit trigger clause such as "Use when generating or reviewing Rails controllers, adding actions, or implementing authorization with Pundit" to satisfy the completeness "when" requirement.

Fold one or two high-signal trigger terms from metadata.triggers (e.g. "before_action", "nested resources") into the description so natural phrasing is discoverable without relying on metadata.

Mention Pundit by name in the description since authorization is a core capability and users often refer to it directly.

Dimension	Reasoning	Score
Specificity	Lists multiple concrete actions — "Review and update existing Rails controllers", "generate new controllers" — plus coverage areas (RESTful conventions, authorization patterns, error handling, code organization), giving comprehensive capability coverage.	5 / 5
Completeness	Has a clear "what" but no "Use when..." clause or equivalent explicit trigger guidance, which per the rubric caps completeness at 3.	3 / 5
Trigger Term Quality	Good natural keyword coverage ("Rails controllers", "RESTful conventions", "authorization patterns", "error handling") but missing common variations a user might say (e.g. Pundit, before_action, nested resources) that appear only in metadata.triggers.	4 / 5
Distinctiveness Conflict Risk	Clearly scoped to the Rails controller niche with low conflict risk, though it could overlap marginally with broader Rails scaffolding or authorization skills.	4 / 5
	Total	16 / 20 Passed

Validation

87%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 14 / 16 Passed

Validation for skill structure

Criteria	Description	Result
skill_md_line_count	SKILL.md is long (652 lines); consider splitting into references/ and linking	Warning
metadata_version	'metadata.version' is missing	Warning

	Total	14 / 16 Passed

Repository: RoleModel/rolemodel-skills
Path: skills/controller-patterns/SKILL.md
Commit: 6d600e9

Reviewed: 5 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.