Content
64%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a comprehensive, highly actionable reference for ArcGIS spatial analysis with excellent executable code examples and useful anti-pattern documentation. Its main weakness is length—the inline coverage of 9+ analysis types makes it a large monolithic document that would benefit from progressive disclosure via separate reference files. Workflow clarity could be improved with explicit error handling and validation patterns.
Suggestions
Move detailed analysis type examples (SliceAnalysis, ShadowCastAnalysis, DimensionAnalysis, measurement analyses) into a separate ANALYSIS-TYPES.md reference file, keeping only ViewshedAnalysis and one measurement example in the main skill as representative patterns.
Add error handling patterns for common failure scenarios (e.g., adding analysis to MapView instead of SceneView, analysis computation failures) to improve workflow clarity.
Add a brief workflow summary at the top showing the general analysis lifecycle: create → add to view → set geometry → watch progress/result → handle errors.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill is fairly efficient with code examples and avoids explaining basic concepts, but it's quite long (~400 lines) with many analysis types that could be split into separate reference files. Some brief descriptive comments (e.g., 'Analysis objects are added to a SceneView's analyses collection') are mildly redundant given the code examples demonstrate this. | 2 / 3 |
Actionability | Every section provides fully executable, copy-paste ready JavaScript code with correct import statements, constructor patterns, and result handling. The anti-pattern examples in Common Pitfalls are especially actionable, showing both wrong and correct approaches. | 3 / 3 |
Workflow Clarity | The ElevationProfileAnalysis example shows a clear workflow (create → add to view → set geometry → watch progress), and the interactive placement section shows abort handling. However, most analysis examples lack explicit validation/verification steps—there's no guidance on error handling for failed analyses or checking if SceneView is ready before adding analyses. | 2 / 3 |
Progressive Disclosure | The skill has good cross-references to related skills and reference samples at the bottom, but the main body is a monolithic document with 9+ analysis types fully inlined. The analysis types could be split into a separate reference file with only the most common patterns kept in the main skill, improving scannability. | 2 / 3 |
Total | 9 / 12 Passed |