Content
64%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a solid, actionable SAST scanning skill with concrete MCP tool parameters, CLI fallback commands, and a well-structured output template. Its main weaknesses are the lack of validation/feedback loops in the workflow (e.g., verifying scan completion before retrieving findings) and some inline content that could be offloaded to reference files. The content is mostly efficient but includes some reference material (vulnerability categories, secure patterns) that could be trimmed or externalized.
Suggestions
Add explicit validation checkpoints in the workflow, e.g., 'Verify scan status is complete before proceeding to Step 2' and 'If get_resource returns no data, retry or inform user of scan failure'.
Move the vulnerability categories table and language-specific secure patterns into separate reference files to reduce the main skill's token footprint and improve progressive disclosure.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The vulnerability categories table and language-specific secure patterns are useful reference material, but the vulnerability table is somewhat redundant given Claude's existing security knowledge. The AI false positive reduction section could be tighter. Overall mostly efficient with some trimming opportunities. | 2 / 3 |
Actionability | Provides concrete MCP tool invocations with specific parameters, executable CLI commands with exact flags, a detailed output template with placeholders, and language-specific secure coding patterns. The guidance is specific and copy-paste ready. | 3 / 3 |
Workflow Clarity | The 4-step workflow is clearly sequenced and logical, but lacks explicit validation checkpoints or feedback loops. There's no guidance on what to do if Step 2 fails, if findings are incomplete, or how to verify the scan actually completed successfully before proceeding to analysis. | 2 / 3 |
Progressive Disclosure | References `references/data-sources.md` for data source policy and mentions other skills like `/endor-scan-full` and `/endor-setup`, showing some progressive disclosure. However, the language-specific patterns and vulnerability categories table could be split into reference files, and no bundle files exist to support the one reference that is made. | 2 / 3 |
Total | 9 / 12 Passed |