128-java-generics
Use when you need to review, improve, or refactor Java code for generics quality — including avoiding raw types, applying the PECS (Producer Extends Consumer Super) principle for wildcards, using bounded type parameters, designing effective generic methods, leveraging the diamond operator, understanding type erasure implications, handling generic inheritance correctly, preventing heap pollution with @SafeVarargs, and integrating generics with modern Java features like Records, sealed types, and pattern matching. Part of the skills-for-java project
77
71%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./skills/128-java-generics/SKILL.mdQuality
Discovery
100%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
This is an excellent skill description that comprehensively covers Java generics with specific, actionable capabilities and clear trigger conditions. It uses proper third-person voice, includes natural developer terminology, and carves out a distinct niche that won't conflict with other Java-related skills. The description is thorough without being padded with fluff.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Lists multiple specific concrete actions: 'review, improve, or refactor Java code for generics quality' with detailed techniques including 'avoiding raw types', 'applying PECS principle', 'using bounded type parameters', 'designing effective generic methods', 'leveraging diamond operator', 'understanding type erasure', 'handling generic inheritance', 'preventing heap pollution with @SafeVarargs', and 'integrating generics with modern Java features'. | 3 / 3 |
Completeness | Clearly answers both what (review, improve, refactor Java generics code with specific techniques) and when ('Use when you need to...' explicitly states the trigger conditions at the start). The 'Use when' clause is present and comprehensive. | 3 / 3 |
Trigger Term Quality | Excellent coverage of natural terms users would say: 'Java code', 'generics', 'raw types', 'PECS', 'wildcards', 'bounded type parameters', 'generic methods', 'diamond operator', 'type erasure', '@SafeVarargs', 'Records', 'sealed types', 'pattern matching'. These are terms Java developers naturally use when discussing generics. | 3 / 3 |
Distinctiveness Conflict Risk | Highly distinctive with a clear niche focused specifically on Java generics. The detailed list of generics-specific concepts (PECS, type erasure, @SafeVarargs, bounded type parameters) makes it unlikely to conflict with general Java skills or other language skills. | 3 / 3 |
Total | 12 / 12 Passed |
Implementation
42%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill functions primarily as a table of contents pointing to a reference file rather than providing actionable guidance itself. While it has good structure and appropriate progressive disclosure, the complete absence of concrete code examples or patterns in the skill body significantly limits its actionability. The constraints section provides useful safety guardrails but the core content lacks the executable guidance that would make it immediately useful.
Suggestions
Add 2-3 concrete before/after code examples demonstrating key patterns (e.g., raw type elimination, PECS application) directly in the skill body
Include at least one complete, executable code snippet showing proper generic method or class design
Add a brief workflow for how to systematically review code for generics issues (e.g., 'Check for raw types -> Apply PECS to collections -> Verify bounded types')
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill lists many topics covered but some bullet points are somewhat verbose and could be tightened. The 'What is covered' section reads more like a feature list than actionable guidance, though it avoids explaining basic concepts Claude would know. | 2 / 3 |
Actionability | The skill provides no concrete code examples, commands beyond basic Maven invocations, or executable guidance. It describes what topics are covered and points to a reference file, but the skill body itself contains no actionable patterns or copy-paste ready code. | 1 / 3 |
Workflow Clarity | The constraints section provides a clear sequence (compile -> apply -> verify) with an explicit blocking condition for compilation failure. However, the actual workflow for applying generics improvements is absent - it just says 'read the reference' without explaining the review/improvement process. | 2 / 3 |
Progressive Disclosure | The skill appropriately serves as an overview with a clear, one-level-deep reference to the detailed guidance file. The structure is clean with well-signaled sections and the reference link is prominently placed. | 3 / 3 |
Total | 8 / 12 Passed |
Validation
100%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 11 / 11 Passed
Validation for skill structure
No warnings or errors.
- Repository
- jabrena/cursor-rules-java
- Commit
7772a1b
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.