fix-clippy

Fix all clippy lint warnings in the project

1.34x

Quality

68%

Does it follow best practices?

Impact

93%

1.34x

Average score across 3 eval scenarios

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.claude/skills/fix-clippy/SKILL.md

Quality

Content

80%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is an exemplar of conciseness for a simple skill: concrete commands, a genuinely useful warning-vs-error tip, and clean two-step structure. Its weakness is the absence of a verification loop after the batch auto-fix, and a small gap in how to locate the remaining warnings once the grep output is stripped of locations.

Suggestions

Add a verification step after `make fix` (e.g., confirm the build/tests still pass, or re-run clippy expecting zero warnings) since auto-fix is a project-wide batch modification.

Show how to get locations for remaining warnings, e.g. run `cargo clippy --tests` without the grep filter (or `--message-format=short`) before fixing manually.

Clarify the final expected state (zero warnings) so the loop has an explicit exit condition.

Dimension	Reasoning	Score
Conciseness	The 26-line body is lean with no over-explanation: two commands, one useful non-obvious tip ("Clippy issues are warnings, not errors. Never grep for error"), and no padding. Every token earns its place.	5 / 5
Actionability	"make fix" and "cargo clippy --tests 2>&1 \| grep \"^warning:\" \| sort -u" are concrete and executable, but the grep filter strips file/line locations, and "find the exact location and fix it manually" gives no follow-up command to surface those locations — a minor gap.	4 / 5
Workflow Clarity	The two-step sequence (auto-fix, then handle remaining warnings) is clear, but `make fix` performs a project-wide batch modification of source files with no validation/verification step afterwards (e.g., confirming the build still passes), which caps workflow clarity at 3 per the batch-operation guideline.	3 / 5
Progressive Disclosure	The skill is under 50 lines, single-purpose, and has no bundle files (no references/, scripts/, or assets/ directories), so well-organized sections alone satisfy progressive disclosure per the simple-skill guideline; the two headed steps are easy to navigate.	5 / 5
	Total	17 / 20 Passed

Description

57%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is clear, concise, and unambiguous about what the skill does, and 'clippy' makes it highly distinct. Its main weakness is the missing 'Use when...' trigger clause and the absence of natural trigger variations, which leave it dependent on the user already saying the word 'clippy'.

Suggestions

Add an explicit trigger clause, e.g. "Use when the user mentions clippy, lint warnings, or wants to clean up Rust code warnings."

Include natural trigger variations users might say, such as "Rust", "cargo clippy", or "fix warnings".

Optionally enumerate the sub-actions (auto-fix via make, manual fixes for remaining warnings) to sharpen the 'what'.

Dimension	Reasoning	Score
Specificity	"Fix all clippy lint warnings in the project" names the domain and a single concrete action, but does not list several distinct actions; it fits the '1-2 concrete actions, not comprehensive' anchor rather than the 'several specific actions' level above.	3 / 5
Completeness	The 'what' is clear (fix clippy lint warnings), but there is no 'Use when...' or equivalent trigger clause, which caps completeness at 3 per the judging guidelines.	3 / 5
Trigger Term Quality	It includes relevant keywords ("clippy", "lint", "warnings") that Rust users would naturally say, but misses common variations such as "Rust", "cargo clippy", or "clean up warnings".	3 / 5
Distinctiveness Conflict Risk	"Clippy" is a highly specific tool name, giving a clear niche with distinct triggers and minimal overlap with other skills.	5 / 5
	Total	14 / 20 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: quickwit-oss/quickwit
Path: .claude/skills/fix-clippy/SKILL.md
Commit: ff79f76

Reviewed: 2 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.