CtrlK
BlogDocsLog inGet started
Tessl Logo

testing-anti-patterns

Reviews test code to identify and fix common testing anti-patterns including flaky tests, over-mocking, brittle assertions, test interdependency, and hidden test logic. Flags bad patterns, explains the specific defect, and provides corrected implementations. Use when reviewing test code, debugging intermittent or unreliable test failures, or when the user mentions flaky tests, test smells, brittle tests, test isolation issues, mock overuse, slow tests, or test maintenance problems.

72

Quality

88%

Does it follow best practices?

Impact

No eval scenarios have been run

SecuritybySnyk

Passed

No known issues

SKILL.md
Quality
Evals
Security

Quality

Content

77%

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

This is a strong, actionable skill with excellent concrete examples for each anti-pattern and a clear review workflow with validation steps. The main weakness is that the content is somewhat long for a single SKILL.md—the eight detailed anti-patterns with full code examples could be split into a reference file to improve progressive disclosure. Minor verbosity in pattern descriptions could be trimmed, but overall the content is well-structured and useful.

Suggestions

Consider extracting the detailed anti-pattern examples (sections 1-8) into a separate ANTI_PATTERNS_REFERENCE.md and keeping only the checklist, workflow, and refactoring strategies in SKILL.md with links to the reference.

Trim the 'Problem:' descriptions since the BAD/GOOD code examples already make the issue self-evident to Claude—a brief inline comment is sufficient.

DimensionReasoningScore

Conciseness

The content is mostly efficient with good code examples, but some explanations are slightly verbose (e.g., the 'Problem:' labels and 'Fix:' lines state things Claude would infer from the code examples). The anti-pattern descriptions could be tighter, though the examples themselves earn their place.

2 / 3

Actionability

Every anti-pattern includes fully executable TypeScript code showing both the bad and good patterns, with concrete before/after examples. The detection checklist and refactoring strategies provide specific, actionable guidance. The review workflow gives clear steps to follow.

3 / 3

Workflow Clarity

The review workflow is clearly sequenced with four explicit steps including a validation checkpoint (step 4: verify the test still fails when code breaks). This feedback loop is appropriate for the task—confirming that refactored tests actually catch regressions. The checklist provides an additional structured verification step.

3 / 3

Progressive Disclosure

The content is well-organized with clear headers and sections, but it's a long monolithic file (~200 lines) that could benefit from splitting detailed anti-pattern examples into a reference file while keeping the checklist and workflow in the main SKILL.md. No bundle files are provided to offload content to.

2 / 3

Total

10

/

12

Passed

Description

100%

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

This is an excellent skill description that hits all the marks. It provides specific concrete actions, comprehensive trigger terms that match natural developer language, explicit 'Use when' guidance, and occupies a clearly distinct niche in test code quality review. The description is well-structured, uses third person voice throughout, and balances detail with conciseness.

DimensionReasoningScore

Specificity

Lists multiple specific concrete actions: identifies and fixes anti-patterns including flaky tests, over-mocking, brittle assertions, test interdependency, and hidden test logic. Also specifies outputs: flags bad patterns, explains defects, and provides corrected implementations.

3 / 3

Completeness

Clearly answers both 'what' (reviews test code to identify/fix anti-patterns, flags bad patterns, explains defects, provides corrected implementations) and 'when' (explicit 'Use when...' clause with multiple trigger scenarios including reviewing test code, debugging intermittent failures, and specific user mentions).

3 / 3

Trigger Term Quality

Excellent coverage of natural terms users would say: 'flaky tests', 'test smells', 'brittle tests', 'test isolation issues', 'mock overuse', 'slow tests', 'test maintenance problems', 'unreliable test failures'. These are all terms developers naturally use when encountering these issues.

3 / 3

Distinctiveness Conflict Risk

Occupies a clear niche focused specifically on test code quality and anti-patterns. The specific trigger terms like 'flaky tests', 'test smells', 'over-mocking', and 'brittle assertions' are highly distinctive and unlikely to conflict with general code review or testing framework skills.

3 / 3

Total

12

/

12

Passed

Validation

90%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation10 / 11 Passed

Validation for skill structure

CriteriaDescriptionResult

frontmatter_unknown_keys

Unknown frontmatter key(s) found; consider removing or moving to metadata

Warning

Total

10

/

11

Passed

Repository
rohitg00/skillkit
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.