Skill: AL Performance Rules (BC SaaS)

// CORRECT: SetLoadFields
Item.SetLoadFields("No.", "Description", "Unit Price");
if Item.FindSet() then repeat /* ... */ until Item.Next() = 0;

// CORRECT: SetCurrentKey for indexed fields
CustLedgEntry.SetCurrentKey("Customer No.", "Posting Date");
CustLedgEntry.SetRange("Customer No.", Customer."No.");
CustLedgEntry.SetFilter("Posting Date", '>=%1', StartDate);

// CORRECT: IsEmpty instead of Count
if Customer.IsEmpty() then exit;

// CORRECT: CalcSums instead of loop
GLEntries.SetFilter("G/L Account No.", AccountFilter);
GLEntries.CalcSums(Amount);
TotalAmount := GLEntries.Amount;

// WRONG: Count() = 0 causes locks
if Customer.Count() = 0 then exit;  // AVOID!

// WRONG: Loop to sum values
repeat
    TotalAmount += GLEntries.Amount;  // AVOID!
until GLEntries.Next() = 0;

// CAUTION: Validate may load additional fields
Customer.SetLoadFields("City");
Customer.FindSet();
repeat
    Customer.Validate(City, Customer.City.Trim());  // May trigger JIT loading!
until Customer.Next() = 0;

// WRONG when records usually exist (e.g., Sales Lines for Sales Header)
if not SalesLine.IsEmpty() then  // Unnecessary query!
    SalesLine.FindSet();

// CORRECT: Just use FindSet when records expected
if SalesLine.FindSet() then
    repeat /* ... */ until SalesLine.Next() = 0;

// Lock only last row for sequence
GLEntry.ReadIsolation := IsolationLevel::UpdLock;
GLEntry.FindLast();
exit(GLEntry."Entry No." + 1);

report 50100 "My Report"
{
    DataAccessIntent = ReadOnly;  // Uses read replica
}

// Page Background Task for heavy calculations
trigger OnAfterGetCurrRecord()
var
    TaskParameters: Dictionary of [Text, Text];
begin
    CurrPage.EnqueueBackgroundTask(TaskId, Codeunit::DoComplexCalculation, TaskParameters);
end;

// WRONG: Passes entire record (creates memory copy)
NoOfOrders := CountOrdersByCustomer(Customer);

local procedure CountOrdersByCustomer(Customer: Record Customer): Integer
begin
    SalesHeader.SetRange("Sell-to Customer No.", Customer."No.");
    exit(SalesHeader.Count());
end;

// CORRECT: Pass only needed field
NoOfOrders := CountOrdersByCustomer(Customer."No.");

local procedure CountOrdersByCustomer(CustomerNo: Code[20]): Integer
begin
    SalesHeader.SetRange("Sell-to Customer No.", CustomerNo);
    exit(SalesHeader.Count());
end;

// ALTERNATIVE: Use var to pass by reference (no copy)
local procedure ProcessCustomer(var Customer: Record Customer)

// CORRECT: TextBuilder for loops
var StringBuilder: TextBuilder;
begin
    foreach Item in Items do
        StringBuilder.AppendLine(Item.Description);
    exit(StringBuilder.ToText());
end;

// WRONG: += in loop - AVOID!
foreach Item in Items do
    Result += Item.Description + '\';

- [ ] SetLoadFields before FindSet/Find on tables with extensions?
- [ ] SetCurrentKey when filtering on non-primary key fields?
- [ ] IsEmpty() instead of Count() = 0? (only when records rarely exist)
- [ ] CalcSums instead of loop for summing?
- [ ] DataAccessIntent = ReadOnly on read-only reports/APIs?
- [ ] TextBuilder for string concatenations in loops?
- [ ] Procedure parameters: fields instead of full records?
- [ ] CommitBehavior on critical integration events?