Review Migration

Use this skill when schema changes must be safe in real environments.

Core principle: Prefer phased rollouts over one-shot migrations on large or busy tables.

Quick Reference

HARD-GATE

DO NOT combine schema change and data backfill in one migration.
DO NOT add NOT NULL on a column that hasn't been fully backfilled.
DO NOT drop columns before all code references are removed.

Review Order

1. Identify the database and table-size risk.
2. Separate schema changes from data backfills.
3. Check lock behavior for indexes, constraints, defaults, and rewrites.
4. Plan deployment order between app code and migration code.
5. Plan rollback or forward-fix strategy.

Safe Patterns

• Add nullable column first, backfill later, enforce NOT NULL last.
• Add indexes concurrently when supported.
• Backfill in batches outside a long transaction when volume is high.
• Deploy code that tolerates both old and new schemas during transitions.
• Use multi-step rollouts for renames, type changes, and unique constraints.

If the project uses strong_migrations, follow it. If it does not, apply the same safety rules manually.

Examples

Risky (avoid):

add_column :orders, :status, :string, default: 'pending', null: false
Order.update_all("status = 'pending'")

• Risk: Long lock; table rewrite if default is applied on large table.

Safe pattern:

# Step 1: add nullable column
add_column :orders, :status, :string

# Step 2 (separate deploy): backfill in batches outside migration

# Step 3 (after backfill): add constraint
change_column_null :orders, :status, false
change_column_default :orders, :status, from: nil, to: 'pending'

Index on large tables:

# PostgreSQL: concurrent index (no write lock)
disable_ddl_transaction!
add_index :orders, :processed_at, algorithm: :concurrent

# MySQL: online DDL
add_index :orders, :processed_at, algorithm: :inplace

Common Mistakes

Red Flags

• Schema change and data backfill combined in one long migration
• Column rename with app code assuming immediate cutover
• Large-table default, rewrite, or NOT NULL change without a phased plan
• Foreign key or unique constraint added before cleaning existing data
• Destructive remove or drop in the same deploy as the replacement path
• No rollback or forward-fix strategy documented

Output Style

List risks first.

For each risk include:

• Migration step
• Likely failure mode or lock risk
• Safer rollout
• Rollback or forward-fix note

For complex type changes, multi-step unique constraints, foreign key validation deferral, safe column removal, and multi-database migrations see PATTERNS.md.

Integration