jbvc/codebase-cleanup-refactor-clean
You are a code refactoring expert specializing in clean code principles, SOLID design patterns, and modern software engineering best practices. Analyze and refactor the provided code to improve its quality, maintainability, and performance.
46
46%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Quality
Discovery
32%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
The description identifies a clear domain (code refactoring) and mentions relevant methodologies (SOLID, clean code), but it lacks concrete action specifics and has no explicit trigger guidance ('Use when...'). It also uses second-person framing ('You are...') which is inappropriate for a skill description — it reads more like a system prompt than a skill selector. The vague outcome language ('improve quality, maintainability, and performance') doesn't help Claude distinguish this skill from other code-related skills.
Suggestions
Add an explicit 'Use when...' clause with trigger terms like 'refactor', 'clean up code', 'code smell', 'technical debt', 'simplify', 'SOLID principles'.
Replace vague outcomes with specific concrete actions, e.g., 'Extracts methods, renames variables, decomposes large classes, removes code duplication, applies SOLID principles'.
Rewrite in third person voice ('Analyzes and refactors code...') instead of the current second-person system-prompt style ('You are a code refactoring expert').
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Names the domain (code refactoring) and some actions ('analyze and refactor'), but the specific capabilities are vague — 'improve quality, maintainability, and performance' are abstract outcomes rather than concrete actions like 'extract methods, rename variables, decompose classes'. | 2 / 3 |
Completeness | Describes what it does (analyze and refactor code) but has no explicit 'Use when...' clause or equivalent trigger guidance. Per the rubric, a missing 'Use when...' clause caps completeness at 2, and the 'what' portion is also somewhat weak, placing this at 1. | 1 / 3 |
Trigger Term Quality | Includes some relevant keywords like 'refactoring', 'clean code', 'SOLID', and 'design patterns' that users might mention, but misses common natural variations like 'code smell', 'technical debt', 'simplify code', 'restructure', or 'DRY'. | 2 / 3 |
Distinctiveness Conflict Risk | The focus on refactoring and SOLID principles provides some distinction, but 'improve code quality' and 'best practices' are broad enough to overlap with general code review, linting, or code generation skills. | 2 / 3 |
Total | 7 / 12 Passed |
Implementation
35%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill is structurally organized but lacks actionable, concrete guidance. The instructions read as high-level principles rather than executable steps — there are no code examples, no specific refactoring patterns, and no concrete validation commands. The skill relies heavily on an external playbook file without providing enough substance in the main body to be independently useful.
Suggestions
Add at least 2-3 concrete code examples showing before/after refactoring patterns (e.g., extract method, replace conditional with polymorphism) to make the skill actionable.
Replace vague instructions like 'Identify high-impact refactor candidates' with specific heuristics or checklists (e.g., 'Look for methods >30 lines, classes with >5 dependencies, duplicated blocks >3 lines').
Add explicit validation steps with concrete commands, e.g., 'Run existing test suite before and after each refactoring step; diff output to confirm no behavioral changes.'
Remove the redundant 'Context' section and the repeated persona description to improve conciseness.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill includes some unnecessary framing (e.g., 'You are a code refactoring expert...' repeated from the description, 'The user needs help refactoring code' context section) and 'when to use/not use' sections that are somewhat verbose. However, the core instructions are reasonably tight. | 2 / 3 |
Actionability | The instructions are entirely abstract and vague — 'Identify high-impact refactor candidates,' 'Apply changes with a focus on readability' — with no concrete code examples, specific commands, patterns, or executable guidance. There's nothing copy-paste ready or specific enough to act on. | 1 / 3 |
Workflow Clarity | There is a rough sequence (identify → break into steps → apply → validate), but validation checkpoints are vague ('Validate with tests and targeted regression checks') with no explicit feedback loops or concrete verification steps. For a refactoring skill involving potentially destructive changes, this lacks sufficient rigor. | 2 / 3 |
Progressive Disclosure | There is a reference to `resources/implementation-playbook.md` for detailed patterns, which is good progressive disclosure. However, the main content itself is thin and abstract — the reference is doing heavy lifting for content that should have at least some concrete examples inline. | 2 / 3 |
Total | 7 / 12 Passed |
Validation
100%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 11 / 11 Passed
Validation for skill structure
No warnings or errors.
Reviewed
Table of Contents