jbvc/git-pr-workflows-git-workflow
Orchestrate a comprehensive git workflow from code review through PR creation, leveraging specialized agents for quality assurance, testing, and deployment readiness. This workflow implements modern g
47
47%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Quality
Discovery
32%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
The description is truncated mid-sentence, which severely undermines its completeness and usefulness. While it touches on relevant domain concepts (git workflow, PR creation, code review), it relies on vague orchestration language and lacks an explicit 'Use when...' clause to guide skill selection.
Suggestions
Complete the truncated description and add an explicit 'Use when...' clause with trigger terms like 'pull request', 'PR', 'code review', 'merge request', 'git commit workflow'.
Replace vague language like 'orchestrate a comprehensive git workflow' and 'leveraging specialized agents' with specific concrete actions (e.g., 'Reviews code diffs, runs tests, creates pull requests, checks deployment readiness').
Add common user-facing trigger terms and file/tool references (e.g., 'pull request', 'PR', 'GitHub', 'GitLab', '.git') to improve keyword coverage.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Names the domain (git workflow, PR creation) and some actions (code review, quality assurance, testing, deployment readiness), but uses vague orchestration language rather than listing concrete specific actions. 'Leveraging specialized agents' is abstract. | 2 / 3 |
Completeness | The description is truncated and only partially addresses 'what' (orchestrate git workflow). There is no 'Use when...' clause or equivalent trigger guidance, and the description cuts off mid-sentence, making it fundamentally incomplete. | 1 / 3 |
Trigger Term Quality | Includes some relevant keywords like 'git workflow', 'PR creation', 'code review', 'testing', and 'deployment readiness', but misses common user terms like 'pull request', 'merge', 'push', 'CI/CD', 'branch'. The description also appears truncated. | 2 / 3 |
Distinctiveness Conflict Risk | Somewhat specific to git workflows and PR creation, but the broad terms like 'quality assurance', 'testing', and 'deployment readiness' could overlap with CI/CD skills, testing skills, or general code review skills. | 2 / 3 |
Total | 7 / 12 Passed |
Implementation
35%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill is overly verbose and padded with generic guidance, extended thinking blocks, and boilerplate sections that don't add value for Claude. While the multi-phase workflow structure is reasonable, it lacks concrete executable commands, explicit validation gates between phases, and proper progressive disclosure. The agent prompts are detailed but read more like documentation of an ideal process than actionable instructions Claude can execute.
Suggestions
Remove the extended thinking block, generic 'Use/Do not use' sections, and best practices that Claude already knows — this could cut 30-40% of tokens while improving clarity.
Add explicit go/no-go gates between phases (e.g., 'If critical issues > 0, STOP and fix before proceeding to Phase 2') to create proper validation feedback loops.
Replace verbose agent prompt descriptions with concrete, executable examples — show actual git commands, actual Task tool invocations with minimal prompts, and expected output formats in separate reference files.
Move the detailed agent prompts for each sub-step into a referenced file (e.g., 'agent-prompts.md') and keep only the phase overview and key decision points in the main SKILL.md.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Extremely verbose with significant padding. The extended thinking block, generic 'Use this skill when' / 'Do not use this skill when' sections, and lengthy agent prompts with inline JSON schemas bloat the content enormously. Much of this describes orchestration concepts Claude already understands. The best practices and rollback sections repeat common knowledge. | 1 / 3 |
Actionability | The skill describes what agents should do with detailed prompts, but provides no actual executable code or commands. Steps like 'Use Task tool with subagent_type=...' give some structure but are essentially pseudocode for orchestration. There are no concrete git commands, no actual script invocations, and the 'open resources/implementation-playbook.md' reference suggests the real actionable content lives elsewhere. | 2 / 3 |
Workflow Clarity | The five-phase structure provides clear sequencing and context passing between phases is mentioned. However, validation checkpoints are weak — there's no explicit 'stop if critical issues found' gate between phases, no feedback loops for fixing issues discovered during review, and the success criteria are listed at the end rather than integrated as go/no-go gates within the workflow. | 2 / 3 |
Progressive Disclosure | There is a reference to 'resources/implementation-playbook.md' for detailed examples, which is good. However, the main file itself is a monolithic wall of text (~200+ lines) with extensive inline agent prompts that could be split into separate reference files. The phases are well-sectioned but the content within each is too detailed for an overview document. | 2 / 3 |
Total | 7 / 12 Passed |
Validation
100%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 11 / 11 Passed
Validation for skill structure
No warnings or errors.
Reviewed
Table of Contents