Content
73%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A strong, highly actionable audit workflow: the five-phase sequence is clearly ordered with explicit read-verification checkpoints and a false-positive feedback loop, and the detection patterns are concrete and executable. The main costs are token weight — redundant Invocation Examples and Scope sections, plus undated-region time-sensitive claims — and a few fixes that describe rather than show the correction.
Suggestions
Cut the 'Invocation Examples' and 'Scope' sections — they duplicate the description's trigger function and Phase 1/2 content, trimming ~40 lines with no capability loss.
Move date-sensitive claims ('since May 2024', 'Since Spring 2024', 'iOS 17+') into a short 'Requirements background' note or strip the dates and keep the requirement itself, so the skill doesn't read as time-stamped.
Add one-line fix code snippets for the top fixes (Keychain storage with kSecAttrAccessibleWhenUnlockedThisDeviceOnly, a PrivacyInfo.xcprivacy stub) to close the gap between concrete searches and described-but-not-shown fixes.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and operational (grep patterns, file globs, tables) with little explanation of concepts Claude already knows, but it contains genuinely trimmable material: the five-entry 'Invocation Examples' section duplicates the description's trigger job, the trailing 'Scope' section restates Phase 1/2 content, and time-sensitive dates ('since May 2024', 'Since Spring 2024', 'iOS 17+') sit outside any deprecated/old-patterns section. This is 'mostly efficient but could be tightened' rather than only minor trims. | 3 / 5 |
Actionability | Concrete, copy-paste-ready search commands throughout — `AKIA[0-9A-Z]{16}`, `sk-[a-zA-Z0-9]{24,}`, `http://[a-zA-Z]`, `NSAllowsArbitraryLoads.*true` — with exact API names in fixes (`kSecAttrAccessibleWhenUnlockedThisDeviceOnly`, `NSUserTrackingUsageDescription`). Minor gaps keep it below fully executable: fix guidance lacks code snippets, and one 'search' is an absence-check ('Absence of `SecTrust`, `TrustKit`') rather than a runnable pattern. | 4 / 5 |
Workflow Clarity | Five explicitly sequenced phases with validation checkpoints and feedback loops: 'For every grep match, use Read to verify the surrounding context before reporting', 'Present this map in the output before proceeding', and a dedicated False Positives section that filters verified matches. The skill is read-only, so the destructive-operation cap does not apply, and the structure matches the anchor for clear sequence with explicit validation steps. | 5 / 5 |
Progressive Disclosure | No bundle files exist, so all content is inline, but the body is well-sectioned with clear phase headers and the 'Related' section provides clean one-level pointers to sibling skills. Some inline material (the Required Reason API mapping, Invocation Examples) could be split into a reference file given the ~320-line size, which is a minor organization gap rather than a structural problem, since the bulk is runtime-critical instruction that correctly stays in the main file. | 4 / 5 |
Total | 16 / 20 Passed |