CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

code-review

Generic checklist for reviewing DevTools CLs (your own before upload, or someone else's on Gerrit). Covers test correctness (tautological/vacuous tests, cleanup, leaks), code clarity, CL hygiene, and points to the specialized skills to consult for imports, UI, testing, strings, models, and verification. Use when asked to review a CL, a diff, a patch, or to self-review before `git cl upload`.

Quality

92%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Low

Low-risk findings worth noting

SKILL.md
Quality
Evals
Security

Quality

Content

96%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

Excellent checklist content: lean, deeply repo-specific, and highly actionable, with concrete commands, exact file paths, and a well-sequenced review workflow that includes an explicit pre-report validation gate. The only notable improvement is moving the detailed false-positive guard explanations into a reference file to keep SKILL.md as a tighter overview.

Suggestions

Move the detailed Lit event/whitespace/.css.js false-positive guard explanations (Section 4) into a reference file (e.g., references/false-positive-guards.md), keeping a one-line summary and pointer in SKILL.md.

Consider splitting Sections 5-6 (test correctness and hygiene) into a reference file as well, since they are the longest checklists and could be loaded on demand when the diff touches tests.

DimensionReasoningScore

Conciseness

The body is dense with repo-specific knowledge Claude would not know (e.g., eventMixin's dispatchDOMEvent mechanics, Lit's `attrNames[]` case preservation, Sinon's "Attempted to wrap…" error) and contains no concept tutorials or padding. It matches anchor 5 — lean, assumes competence, every token earns its place — with nothing trimmable to justify anchor 4.

5 / 5

Actionability

Provides copy-paste-ready commands (`git diff origin/main...HEAD`, the full Gerrit `curl` for inline comments), exact file paths, and concrete fix patterns (`try { … } finally { clock.restore(); }`, "have the CDP stub emit `CSSModel.Events.StyleSheetChanged`"). Per the rubric's instruction-skill note, this fully matches anchor 5's executable, common-case-covering guidance; only trivial placeholders like `<CL_NUMBER>` remain.

5 / 5

Workflow Clarity

A clear numbered sequence (gather context → consult specialized skills → boundaries → false-positive guards → correctness/hygiene checks → write comments) with an explicit pre-report validation checkpoint: "Check these guards before reporting any finding (including general review findings)". This matches anchor 5's explicit validation steps and checklist for a complex process; review is read-only so the destructive/batch cap does not apply.

5 / 5

Progressive Disclosure

The routing table defers detail to 16+ specialized skills and `.agents/rules/` files with one-level-deep, clearly signaled references — good structure matching anchor 4. It falls short of anchor 5 because the ~35-line Section 4 false-positive guards detail is inlined in a 175-line SKILL.md where a reference file could carry it, a minor organization gap.

4 / 5

Total

19

/

20

Passed

Description

83%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong description that explicitly states both what the skill covers and when to use it, with concrete DevTools-specific framing and natural trigger synonyms. Its main weaknesses are minor: trigger coverage misses a few common phrasings, and the generic "review a diff/patch" triggers create slight overlap risk with general code-review skills.

Suggestions

Add "code review" (and optionally "Gerrit") to the 'Use when' clause to capture the most common phrasing users would naturally say.

Scope the trigger phrases to the DevTools/Chromium context (e.g., "Use when asked to review a DevTools CL, diff, or patch, or to self-review before `git cl upload`") to reduce overlap with generic code-review skills.

DimensionReasoningScore

Specificity

"Covers test correctness (tautological/vacuous tests, cleanup, leaks), code clarity, CL hygiene, and points to the specialized skills… for imports, UI, testing, strings, models, and verification" names several specific coverage areas with concrete subtypes. This matches anchor 4 (several specific actions, minor gaps) rather than 5, since capabilities are framed as checklist areas rather than a comprehensive list of concrete actions, and is well above anchor 3's 1-2 actions.

4 / 5

Completeness

Explicitly answers both: the what ("Generic checklist for reviewing DevTools CLs… Covers test correctness…, code clarity, CL hygiene") and the when with concrete trigger phrases ("Use when asked to review a CL, a diff, a patch, or to self-review before `git cl upload`"). This matches anchor 5 exactly; the when-clause is explicit and specific, so anchor 4's weaker 'when' does not apply.

5 / 5

Trigger Term Quality

"Use when asked to review a CL, a diff, a patch, or to self-review before `git cl upload`" provides good natural-term coverage with synonyms (CL, diff, patch, self-review). It falls short of anchor 5's comprehensive coverage because common phrasings like "code review" are absent and "Gerrit" appears only in the what-clause rather than as a trigger.

4 / 5

Distinctiveness Conflict Risk

"DevTools CLs", "on Gerrit", and "git cl upload" establish a clear Chromium-specific niche, but the trigger phrases "review a CL, a diff, a patch" are generic and could overlap with a general code-review skill. This matches anchor 4 (mostly distinct, minor overlap risk with closely related skills) rather than anchor 5's minimal conflict risk.

4 / 5

Total

17

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository

ChromeDevTools/devtools-frontend

Path

.agents/skills/code-review/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.