Content
46%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is rich with domain-specific implementation detail and code, but it is structured as an inline monolith: full class implementations live in SKILL.md while the reference files they should live in are listed but missing from the bundle. Workflows lack validation checkpoints, and several code blocks are non-executable stubs.
Suggestions
Create the advertised bundle files (references/billing-cycles.md, dunning-management.md, proration.md, tax-calculation.md, invoice-lifecycle.md, assets/*.yaml/html) and move the inline class implementations into them, keeping SKILL.md as a concise overview with clearly signaled one-level-deep links.
Add explicit validation checkpoints to the billing workflow (e.g., verify invoice totals before charging, confirm tax jurisdiction resolution, test-mode charge before live charge, verify dunning retry count before cancellation) so destructive/batch operations have a verify-then-proceed loop.
Cut the 'Core Concepts' section and make the code self-contained: either import real dependencies (stripe, reportlab) or remove pass-stub methods like to_pdf() and validate_vat_number(), so the examples are executable rather than illustrative.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly efficient, but the 'Core Concepts' section pads with knowledge Claude already has (listing 'Monthly, Annual, Quarterly, Weekly' intervals, defining dunning and proration in prose), and the ~400 lines of class implementations could be tightened — e.g., the full Invoice.to_html template string and pass-stub methods. | 3 / 5 |
Actionability | Concrete code is provided throughout, but it is illustrative rather than executable: it depends on an undefined `billing` module, plus undefined `generate_id()`, `PaymentResult`, `send_email`, `UsageRecord`, `DunningAttempt`, and `to_pdf`/`validate_vat_number` are `pass` stubs — more than minor gaps. | 3 / 5 |
Workflow Clarity | The billing-cycle sequence exists (generate invoice → charge → advance period or start dunning) but is embedded in code rather than stated as a workflow, and there are no validation checkpoints for operations that charge customers and cancel subscriptions — a cap per the batch/destructive-operations guideline. | 3 / 5 |
Progressive Disclosure | The Resources section lists references/ and assets/ files, but none of those files exist in the bundle — every reference is dangling — while ~400 lines of implementation code (proration, tax, invoices, usage billing) that clearly belongs in those separate files is inlined in SKILL.md. | 2 / 5 |
Total | 11 / 20 Passed |