code-review-excellence
Master effective code review practices to provide constructive feedback, catch bugs early, and foster knowledge sharing while maintaining team morale. Use when reviewing pull requests, establishing review standards, or mentoring developers.
65
51%
Does it follow best practices?
Impact
86%
1.28xAverage score across 3 eval scenarios
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./tests/ext_conformance/artifacts/agents-wshobson/developer-essentials/skills/code-review-excellence/SKILL.mdQuality
Discovery
67%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
The description has good structural completeness with an explicit 'Use when' clause and covers the domain reasonably well. However, it leans toward aspirational outcomes ('foster knowledge sharing,' 'maintaining team morale') rather than concrete actions, and could benefit from more specific trigger terms and sharper action language to better distinguish it from general software development or mentoring skills.
Suggestions
Replace outcome-oriented phrases like 'foster knowledge sharing' and 'maintaining team morale' with concrete actions such as 'annotate diffs, suggest code improvements, flag security issues, enforce coding standards.'
Expand trigger terms to include common variations like 'PR review,' 'merge request,' 'code feedback,' 'reviewing diffs,' or 'approve changes.'
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | The description names the domain (code review) and mentions some actions like 'provide constructive feedback, catch bugs early, foster knowledge sharing,' but these are more like goals/outcomes than concrete specific actions. It lacks specifics like 'comment on diffs, approve/request changes, check for security vulnerabilities.' | 2 / 3 |
Completeness | Clearly answers both 'what' (effective code review practices for constructive feedback, catching bugs, knowledge sharing) and 'when' with an explicit 'Use when' clause covering pull requests, review standards, and mentoring developers. | 3 / 3 |
Trigger Term Quality | Includes some natural keywords like 'pull requests,' 'code review,' 'review standards,' and 'mentoring developers,' but misses common variations like 'PR review,' 'CR,' 'code feedback,' 'merge request,' or 'reviewing code changes.' | 2 / 3 |
Distinctiveness Conflict Risk | While 'code review' and 'pull requests' provide some specificity, the description's mention of 'mentoring developers' and 'knowledge sharing' could overlap with general mentoring or team collaboration skills. The scope is somewhat broad for a single skill. | 2 / 3 |
Total | 9 / 12 Passed |
Implementation
35%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill is comprehensive but severely over-scoped for a SKILL.md file. It reads more like a code review handbook than a concise skill instruction, explaining many concepts Claude already understands (feedback etiquette, common anti-patterns, soft skills). The language-specific examples and checklists provide some actionable value, but the majority of content is educational padding that wastes token budget.
Suggestions
Reduce content by 60-70%: Remove sections on review mindset, giving difficult feedback, handling disagreements, and common pitfalls—these are general knowledge Claude already possesses.
Move language-specific patterns, security checklists, and advanced review patterns into separate referenced files, keeping SKILL.md as a concise overview with the core workflow and templates only.
Add explicit validation checkpoints to the review workflow, such as 'Verify all blocking issues are labeled before submitting' or 'Confirm CI status before approving.'
Focus the main file on the actionable review process and templates, cutting the philosophical/educational content that doesn't directly instruct Claude on what to do.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Extremely verbose at ~400+ lines. Explains concepts Claude already knows well (what code review is, what good feedback looks like, basic Python/TypeScript anti-patterns). Extensive sections on soft skills, mindset, and common pitfalls that are general knowledge for an LLM. Much of this content (e.g., 'Goals of Code Review', 'Not the Goals', 'Common Pitfalls') is padding that doesn't add actionable value. | 1 / 3 |
Actionability | Contains concrete code examples for language-specific patterns (Python mutable defaults, TypeScript error handling) and usable templates/checklists. However, much of the content is descriptive guidance rather than executable instructions—it tells Claude about code review philosophy rather than giving it specific steps to execute when performing a review. The checklists are actionable but the surrounding content is more educational than instructional. | 2 / 3 |
Workflow Clarity | The four-phase review process (Context Gathering → High-Level → Line-by-Line → Summary) provides a clear sequence with time estimates. However, there are no validation checkpoints or feedback loops—no steps for verifying that the review itself is complete or that identified issues have been properly categorized. The phases are listed but lack explicit decision points or error recovery. | 2 / 3 |
Progressive Disclosure | References external files at the end (references/code-review-best-practices.md, scripts/pr-analyzer.py, etc.) which is good structure. However, the main file itself is a monolithic wall of content that should have been split—language-specific patterns, security checklists, and advanced patterns could each be separate referenced files. The inline content is far too long for a SKILL.md overview. | 2 / 3 |
Total | 7 / 12 Passed |
Validation
90%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 10 / 11 Passed
Validation for skill structure
| Criteria | Description | Result |
|---|---|---|
skill_md_line_count | SKILL.md is long (539 lines); consider splitting into references/ and linking | Warning |
Total | 10 / 11 Passed | |
- Repository
- Dicklesworthstone/pi_agent_rust
- Commit
6e3d68c
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.