design-patterns
Detect, suggest, and evaluate GoF design patterns in TypeScript/JavaScript codebases. Use when refactoring code, applying singleton/factory/observer/strategy patterns, reviewing pattern quality, or finding stack-native alternatives for React, Angular, NestJS, and Vue.
74
71%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./examples/skills/design-patterns/SKILL.mdQuality
Discovery
100%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
This is a strong, well-crafted skill description that clearly communicates its purpose, lists concrete actions, includes an explicit 'Use when' clause with rich trigger terms, and occupies a distinct niche. It uses proper third-person voice and covers both the 'what' and 'when' comprehensively with specific pattern names and framework targets.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Lists multiple specific concrete actions: 'detect', 'suggest', and 'evaluate' GoF design patterns, plus mentions refactoring, applying specific patterns (singleton/factory/observer/strategy), reviewing pattern quality, and finding stack-native alternatives for named frameworks. | 3 / 3 |
Completeness | Clearly answers both what ('Detect, suggest, and evaluate GoF design patterns in TypeScript/JavaScript codebases') and when ('Use when refactoring code, applying singleton/factory/observer/strategy patterns, reviewing pattern quality, or finding stack-native alternatives for React, Angular, NestJS, and Vue'). | 3 / 3 |
Trigger Term Quality | Excellent coverage of natural terms users would say: 'design patterns', 'singleton', 'factory', 'observer', 'strategy', 'refactoring', 'TypeScript', 'JavaScript', 'React', 'Angular', 'NestJS', 'Vue', 'GoF'. These are terms developers naturally use when seeking pattern guidance. | 3 / 3 |
Distinctiveness Conflict Risk | Highly distinctive niche combining GoF design patterns specifically with TypeScript/JavaScript and named frameworks. Unlikely to conflict with general code review skills or framework-specific skills due to the clear focus on design pattern detection and evaluation. | 3 / 3 |
Total | 12 / 12 Passed |
Implementation
42%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill is comprehensive and well-organized with good progressive disclosure and clear operating modes, but it is severely bloated with content that either Claude already knows (GoF pattern definitions, code smell descriptions) or that belongs in the referenced external files (full output templates, detection heuristics). The workflows lack validation checkpoints, and the actionability suffers from pseudo-code workflows and undefined slash command interfaces rather than executable implementation details.
Suggestions
Reduce token usage by 60-70%: move the full JSON/Markdown output templates, detection heuristics, and code smell mappings into the referenced YAML/MD files (signatures/detection-rules.yaml, etc.) and keep only a brief example of each output format in SKILL.md
Remove explanations of concepts Claude already knows: GoF pattern categorization (Creational 5, Structural 7, Behavioral 11), what code smells are, and SOLID principle definitions
Add validation checkpoints to workflows: e.g., after stack detection verify confidence threshold before proceeding, after pattern detection filter false positives above a threshold, include error handling for missing package.json or ambiguous stack detection
Make the execution model concrete: either provide actual tool-use sequences (Glob → Grep → Read with specific tool calls) or clarify that the slash commands are conceptual triggers, and show how Claude should actually use available tools to implement each phase
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Extremely verbose at ~400+ lines. Includes extensive JSON output examples, full markdown report templates, and detailed heuristic descriptions that could be in reference files. Much of this content (GoF pattern definitions, code smell mappings, detection heuristics) is knowledge Claude already possesses. The adaptation table and scoring guidelines are useful but the output format examples alone consume hundreds of tokens showing complete JSON/markdown templates. | 1 / 3 |
Actionability | Provides concrete output format examples and detection heuristics (grep patterns, file naming conventions), but the actual execution is described in pseudocode-like workflow blocks rather than executable code. The CLI-style invocations (`/design-patterns detect src/`) suggest a slash command interface but no implementation is provided. The adaptation logic uses pseudo-IF/THEN rather than executable code. | 2 / 3 |
Workflow Clarity | Each mode has a numbered workflow (5 phases each), and the overall methodology is broken into clear phases. However, there are no validation checkpoints or error recovery steps. What happens if stack detection fails? What if pattern detection returns false positives? No feedback loops exist for verifying detection accuracy or handling edge cases in the analysis pipeline. | 2 / 3 |
Progressive Disclosure | Well-structured with clear section hierarchy (Operating Modes → Methodology → Output Formats → Constraints). References to external files are one level deep and clearly signaled (reference/patterns-index.yaml, signatures/detection-rules.yaml, etc.). The Reference Files section provides a clean index. Content is logically organized for discovery. | 3 / 3 |
Total | 8 / 12 Passed |
Validation
72%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 8 / 11 Passed
Validation for skill structure
| Criteria | Description | Result |
|---|---|---|
skill_md_line_count | SKILL.md is long (567 lines); consider splitting into references/ and linking | Warning |
allowed_tools_field | 'allowed-tools' contains unusual tool name(s) | Warning |
frontmatter_unknown_keys | Unknown frontmatter key(s) found; consider removing or moving to metadata | Warning |
Total | 8 / 11 Passed | |
- Commit
746adc8
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.