gerrit-system-logic

Provides rules, patterns, and best practices for Gerrit backend system logic, Java APIs, performance, and correctness.

Quality

57%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Critical

Do not install without reviewing

Fix and improve this skill with Tessl

tessl review fix ./configs/skills/gerrit_system_logic/SKILL.md

Quality

Content

65%

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable, with concrete Don't/Do Java examples and real Gerrit APIs throughout, and is well-organized into navigable chapters. Its weaknesses are pervasive Rule/What redundancy inflating an already-massive single-file guide and the absence of explicit validation checkpoints and external progressive-disclosure references.

Suggestions

Collapse the duplicated 'Rule' and 'What' fields per rule into a single statement to remove the near-verbatim repetition and cut hundreds of lines.

Add explicit validation checkpoints to the multi-step/destructive rules (e.g., T2-01: 'verify all instances read V2 before deploying the V2 writer') to establish validate->fix->retry feedback loops.

Split the 13 chapters into one-level-deep reference files (e.g. references/jgit-concurrency.md) and keep SKILL.md as a concise overview with signaled links, so progressive disclosure can reach the level-3 anchor.

Dimension	Reasoning	Score
Conciseness	The content is specialized Gerrit tribal knowledge rather than concepts Claude already knows, but at 2559 lines it carries pervasive redundancy: each rule's 'What' restates the 'Rule' almost verbatim, and the Executive Summary plus per-chapter Summary tables duplicate the chapter Context blocks, so it is 'mostly efficient but could be tightened' rather than lean.	2 / 3
Actionability	Nearly every rule pairs a concrete 'Don't' anti-pattern with an executable 'Do' Java snippet referencing real Gerrit APIs (e.g. try-with-resources RevWalk isolation, permissionBackend.user(...).test(ChangePermission.SUBMIT_AS)), matching the 'fully executable code/commands; specific examples; copy-paste ready' anchor.	3 / 3
Workflow Clarity	Cross-Domain Dependencies map upstream/downstream ordering and rules like T2-01 describe a two-step rollout, but the guide lacks explicit validation checkpoints or validate->fix->retry feedback loops for its destructive/batch operations (schema rollouts, merges, batch updates), which caps workflow clarity at 2 per the rubric.	2 / 3
Progressive Disclosure	The guide is well-organized into 13 chapters with headers, summary tables, and cross-links, but it is a single 2559-line monolithic SKILL.md with no bundle files and no one-level-deep references, fitting 'content that should be separate is inline' rather than the split, well-signaled reference structure of the level-3 anchor.	2 / 3
	Total	9 / 12 Passed

Description

50%

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description clearly identifies the Gerrit backend domain and its scope but relies on abstract action verbs and omits any explicit 'Use when' trigger guidance, leaving every dimension at the mid-level anchor.

Suggestions

Replace abstract verbs with concrete capabilities, e.g. 'Enforces per-thread JGit isolation, two-step NoteDb schema rollouts, and hierarchical REST API routing rules for Gerrit backend changes.'

Add an explicit trigger clause, e.g. 'Use when modifying Gerrit backend Java code, JGit concurrency, NoteDb serialization, REST API payloads, or Bazel build configuration.'

Surface the natural domain terms users would actually say (JGit, NoteDb, code review, REST API, Guice, Bazel) to improve trigger coverage and distinctiveness.

Dimension	Reasoning	Score
Specificity	The phrase 'Provides rules, patterns, and best practices for Gerrit backend system logic, Java APIs, performance, and correctness' names the domain clearly but the actions ('provides rules, patterns, and best practices') are abstract rather than concrete verbs like 'extract' or 'merge', so it does not reach the level-3 'multiple specific concrete actions' anchor.	2 / 3
Completeness	It answers 'what' (rules/patterns/best practices for Gerrit backend logic) but contains no 'Use when...' clause or equivalent explicit trigger guidance, so per the rubric completeness is capped at 2.	2 / 3
Trigger Term Quality	Terms like 'Gerrit', 'Java APIs', 'performance', and 'correctness' are relevant, but it misses the more specific natural terms a Gerrit engineer would actually say (e.g., 'code review', 'JGit', 'NoteDb', 'REST API', 'Guice'), landing at the 'some relevant keywords but missing common variations' anchor rather than full coverage.	2 / 3
Distinctiveness Conflict Risk	The Gerrit backend niche is fairly distinct, but the generic qualifiers 'performance', 'correctness', and 'best practices' could overlap with general engineering skills, so it sits at 'somewhat specific but could still overlap with similar skills' rather than a clear conflict-free niche.	2 / 3
	Total	8 / 12 Passed

Validation

93%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 15 / 16 Passed

Validation for skill structure

Criteria	Description	Result
skill_md_line_count	SKILL.md is long (2560 lines); consider splitting into references/ and linking	Warning

	Total	15 / 16 Passed

Repository: GerritCodeReview/gerrit
Path: configs/skills/gerrit_system_logic/SKILL.md
Commit: 32dbdfa

Reviewed: 4 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.