Content
35%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill identifies the right rules and anti-patterns for lifecycle-aware state collection on Android, but critically lacks any executable code examples—the core pattern (repeatOnLifecycle in a Fragment) is never shown. The referenced implementation template doesn't exist in the bundle, leaving the skill without actionable guidance. The content is reasonably concise but trades too much substance for brevity.
Suggestions
Add a concrete, copy-paste-ready code example showing `repeatOnLifecycle(Lifecycle.State.STARTED)` collecting a StateFlow in a Fragment's `onViewCreated`.
Include the referenced `references/implementation.md` bundle file or inline the template if it's short enough.
Add a brief before/after anti-pattern code snippet showing the deprecated `launchWhenStarted` replaced by `repeatOnLifecycle` to make the anti-patterns section actionable.
Remove the 'Priority: P1' header as it adds no instructional value for Claude.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly efficient but includes some unnecessary elements like the 'Why' explanation for repeatOnLifecycle (Claude knows why lifecycle-aware collection matters) and the Priority header adds no instructional value. The 'LiveData vs Flow' section is reasonably tight. | 2 / 3 |
Actionability | No executable code examples are provided anywhere in the body. The skill describes rules ('ALWAYS use repeatOnLifecycle') but never shows the actual code pattern, making it vague direction rather than concrete guidance. The implementation template is referenced but the bundle file doesn't exist. | 1 / 3 |
Workflow Clarity | The skill clearly states what to do and what not to do (anti-patterns), but there's no sequenced workflow for implementing state collection in a Fragment/Activity. For a skill about integrating ViewModel state with Views, a step-by-step pattern showing the setup would improve clarity. | 2 / 3 |
Progressive Disclosure | There is a reference to 'references/implementation.md' for the Flow Consumption Template, which is appropriate progressive disclosure. However, the bundle file doesn't exist (no bundle files provided), so the reference is broken, and the main content lacks enough substance to stand on its own without it. | 2 / 3 |
Total | 7 / 12 Passed |