Content
43%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is a well-organized security reference with concrete API names, but it lacks an executable workflow with validation checkpoints and repeats a few rules across sections. A broken second reference ('common/security-standards') weakens navigation.
Suggestions
Remove the dangling 'common/security-standards' reference or create the corresponding file so both References entries resolve to real bundle files.
Consolidate the secrets/API-keys guidance into a single location to eliminate the triple restatement across Principles, Anti-Patterns, and the checklist.
Add a short sequenced workflow with an explicit validation checkpoint (e.g., audit trust-marking calls -> verify CSP headers -> confirm HttpOnly cookies) so the skill reads as a process rather than only principles.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly efficient with terse bullets and bold emphasis, but the 'Secrets' rule is restated three times (Principles, Anti-Patterns, and the CSP/secret checklist) and 'NOT use innerHTML' phrasing adds padding that could be tightened. | 3 / 5 |
Actionability | Names concrete APIs (DomSanitizer.sanitize(SecurityContext.HTML, content), CanActivateFn, inject(Router).createUrlTree(['/login']), canActivate: [authGuard]) but the body provides only fragments rather than complete, copy-paste executable blocks; the working example lives in the reference file. | 3 / 5 |
Workflow Clarity | This is a principles/anti-patterns reference rather than a sequenced process; there is no multi-step workflow and no validation checkpoints, and the closing checklist is a flat list, not a sequenced flow with feedback loops. | 2 / 5 |
Progressive Disclosure | Sections are organized and one reference (references/security-best-practices.md) resolves to a real one-level-deep file, but 'common/security-standards' is a dangling reference with no corresponding bundle file or directory, muddying navigation. | 3 / 5 |
Total | 11 / 20 Passed |