Content
67%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A practical, highly actionable testing style guide whose project-specific rules (async mode, module imports, in-memory transport, v3 API accessor, inline snapshots) are the real value. Its main cost is token weight from generic pytest best-practice sections that duplicate what Claude already knows.
Suggestions
Trim or cut the generic sections (Fixtures, Mocking, Error Testing, Test Naming) to one-line reminders, keeping the project-specific rules as the bulk of the skill.
Replace placeholder functions like calculate(-1) and connect_to_invalid_host() with realistic fastmcp-based examples so every snippet is copy-paste executable.
Consider moving the checklist and command reference to the top so the highest-frequency guidance is encountered first.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The project-specific rules (asyncio_mode auto, module-level imports, in-memory transport, the 'result.data' v3 constraint, uv run commands, inline-snapshot) earn their tokens, but the Fixtures, Mocking, Error Testing, and Test Naming sections largely restate standard pytest knowledge Claude already has. | 3 / 5 |
Actionability | Nearly all guidance is executable copy-paste code with concrete commands ('uv run pytest -n 2 -k', '--inline-snapshot=create'), though a few examples rely on placeholder functions like calculate(-1) and connect_to_invalid_host(). | 4 / 5 |
Workflow Clarity | As a guideline skill rather than a sequential process, each action is unambiguous and anchored by a pre-submit checklist and a 'Running Tests' verification section; no validation cap applies since the skill is not destructive or batch-oriented. | 4 / 5 |
Progressive Disclosure | No bundle files exist; the ~230-line body is organized into clean, well-ordered sections with a clearly cited external reference. Structure is good, though the single inline file is slightly too large for pure section organization alone to merit a 5. | 4 / 5 |
Total | 15 / 20 Passed |