Content
64%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a solid, actionable skill with excellent executable code examples and important project-specific constraints (asyncio_mode auto, in-memory transport, result.data v3 API). Its main weaknesses are moderate verbosity from explaining general testing principles Claude already knows, and a monolithic structure that could benefit from splitting general pytest knowledge from project-specific rules. The checklist is a nice touch but could be better integrated into a workflow.
Suggestions
Trim general testing advice Claude already knows (e.g., 'A test that tests multiple things is harder to debug and maintain', 'Mock external services, not internal classes') and focus token budget on project-specific rules and constraints.
Consider splitting into SKILL.md (quick reference with project-specific rules, constraints, and checklist) and a PATTERNS.md (detailed examples of fixtures, mocking, parameterization) to improve progressive disclosure.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Generally efficient but includes some unnecessary guidance Claude already knows (e.g., 'A test that tests multiple things is harder to debug and maintain', 'Don't parameterize unrelated behaviors', 'Test your code with real implementations when possible'). The 'bad' examples add bulk. However, the project-specific rules (asyncio_mode auto, in-memory transport, result.data v3 constraint) are genuinely valuable non-obvious information. | 2 / 3 |
Actionability | Excellent executable examples throughout — parameterization, fixtures, mocking, error testing, inline snapshots, and in-memory transport patterns are all copy-paste ready with real code. The API version constraint with specific accessor names is highly actionable. CLI commands for running tests and inline-snapshot are concrete. | 3 / 3 |
Workflow Clarity | The checklist at the end provides a good validation step, and the inline-snapshot commands give a clear workflow for snapshot testing. However, there's no explicit end-to-end workflow for writing a test (e.g., write → run → validate → fix cycle). The skill is more of a reference than a guided workflow, which is acceptable for this topic, but the checklist could be better integrated into a sequential process. | 2 / 3 |
Progressive Disclosure | The content is well-organized with clear section headers, but it's a fairly long monolithic document (~170 lines) with no references to supporting files. Some sections like the full mocking guide, fixture patterns, or the inline-snapshot details could be split out. The single external reference to FastMCP testing docs is appropriate but the skill could benefit from splitting project-specific rules vs general pytest guidance. | 2 / 3 |
Total | 9 / 12 Passed |