pr-readiness-check
Check branch changes for common PR readiness issues (missing tests, missing JSDoc, guideline violations). Use when the user asks to verify changes before opening a PR, check code quality, or audit a branch for missing items.
95
93%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Quality
Discovery
100%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
This is a well-crafted skill description that clearly communicates its purpose, lists specific capabilities, and includes an explicit 'Use when' clause with natural trigger terms. It uses proper third-person voice and is concise without being vague. It serves as a strong example of an effective skill description.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Lists multiple specific concrete actions: checking for missing tests, missing JSDoc, and guideline violations. These are clear, actionable capabilities rather than vague language. | 3 / 3 |
Completeness | Clearly answers both 'what' (check branch changes for missing tests, missing JSDoc, guideline violations) and 'when' (explicit 'Use when' clause covering verify before PR, check code quality, audit branch for missing items). | 3 / 3 |
Trigger Term Quality | Includes strong natural trigger terms users would say: 'PR readiness', 'verify changes', 'opening a PR', 'check code quality', 'audit a branch', 'missing tests', 'missing JSDoc'. These cover common variations of how users would phrase such requests. | 3 / 3 |
Distinctiveness Conflict Risk | Has a clear niche focused on PR readiness checks and branch auditing. The combination of PR-specific context, branch changes, and specific check types (tests, JSDoc, guidelines) makes it distinctly identifiable and unlikely to conflict with general code review or linting skills. | 3 / 3 |
Total | 12 / 12 Passed |
Implementation
87%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a well-crafted skill that is concise, actionable, and well-structured. It provides specific patterns to detect, exact commands to run, and clear output formatting. The only minor weakness is that the workflow could better define how to handle ambiguous cases (e.g., what constitutes 'non-trivial logic changes' or 'significant logic changes').
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Every section is lean and purposeful. No unnecessary explanations of what PRs are, what diffs are, or how git works. The heuristics and violation patterns are stated directly without preamble. | 3 / 3 |
Actionability | Provides exact git commands to run, specific file naming conventions to check (Foo.ts → Foo.test.ts), concrete anti-patterns to detect (StyleSheet.create(), `any` type, raw View/Text imports), and precise output format with example warning lines. | 3 / 3 |
Workflow Clarity | Steps are clearly sequenced (collect diff → check tests → check JSDoc → check guidelines → output), but this is a non-destructive read-only check so feedback loops are less critical. However, there's no guidance on what to do when findings are ambiguous (e.g., how to determine 'non-trivial logic changes' vs config), and no explicit checkpoint between steps. The workflow is adequate but could be tighter on edge case handling. | 2 / 3 |
Progressive Disclosure | The skill is appropriately self-contained for its scope while referencing external files (ready-for-review.md, CODING_GUIDELINES.md, .cursor/rules/) at one level deep with clear signaling. The content is well-organized into logical sections without being monolithic. | 3 / 3 |
Total | 11 / 12 Passed |
Validation
100%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 11 / 11 Passed
Validation for skill structure
No warnings or errors.
- Repository
- MetaMask/metamask-mobile
- Commit
d8db24a
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.