Content
57%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A thorough, example-rich Bats reference that is strong on executable patterns (assertions, mocking, stubbing, fixtures, CI integration) but reads as an exhaustive catalog rather than a skill: it restates shell basics Claude already knows, provides no sequenced test-writing workflow with verification steps, and keeps everything inline in one long file instead of splitting into reference files. Minor correctness slips (undefined skip_if, macOS-only stat flag) slightly reduce copy-paste reliability.
Suggestions
Split the body into one-level-deep reference files (e.g. references/assertions.md, references/mocking.md, references/ci-integration.md) and keep SKILL.md as a concise overview with clearly signaled links, shedding content Claude already knows such as basic [ -f ] / [ -r ] file checks.
Add an explicit end-to-end workflow with validation checkpoints: create test file → run `bats tests/` → read TAP output → fix and re-run, so users get a sequenced process instead of a pattern catalog.
Fix correctness gaps: define or remove `skip_if` (not a bats-core builtin), note that `stat -f %OLp` is macOS-only (GNU uses `stat -c %a`), and make the "Output matches string" example use Bats' run/output consistently.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Prose is lean and example-driven, but the ~630-line body reiterates shell basics Claude already knows — e.g. "File is readable" (touch + [ -r ]), plain echo string comparisons, exit-code assertions repeated across three sections — and the same patterns are demonstrated redundantly. Not 2 because there is no padded conceptual explanation and the code blocks carry the weight. | 3 / 5 |
Actionability | Nearly all guidance is concrete, executable Bats code — run/status/output assertions, a complete create_stub helper, setup/teardown/hooks, CI YAML, and Makefile targets. Not 5 because `skip_if` is used without being defined (it is not a bats-core builtin), `stat -f %OLp` is macOS-only with no Linux note, and the "Output matches string" example mixes non-Bats `result=$(...)` style into a Bats context. | 4 / 5 |
Workflow Clarity | Sections are ordered sensibly (install → file structure → assertions → fixtures → mocking → CI) but the body is a pattern catalog, not a sequenced workflow: there is no explicit "create test file → run bats → interpret TAP output → iterate" path and no validation checkpoints or feedback loops. The rough sequence and absence of checkpoints place it at 3 rather than 4. | 3 / 5 |
Progressive Disclosure | The file has clear section headers and a Resources section of external links, but there are no bundle files (references/, scripts/, assets/ all absent) and all ~600 lines live inline in SKILL.md — the assertion-pattern catalog and CI/CD integration are exactly the material that belongs in one-level-deep reference files. Good in-file structure keeps it at 3 rather than 2. | 3 / 5 |
Total | 13 / 20 Passed |