CtrlK
BlogDocsLog inGet started
Tessl Logo

1k-code-review-pr

Review OneKey PRs and diffs for security, correctness, concurrency, React/RN pitfalls, and repository-specific regressions. Use for code review or 审查 PR.

68

Quality

83%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

SecuritybySnyk

Low

Low-risk findings worth noting

SKILL.md
Quality
Evals
Security

Quality

Content

82%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A highly actionable, well-sequenced review skill that delegates detail to four real reference files and assumes Claude's competence throughout. Its main weakness is mild verbosity from repeated mandatory-emphasis and a sizable inlined template/scoring section.

Suggestions

Move the full report template and/or the priority/confidence/auto-fix lookup tables into a reference file to slim SKILL.md and improve progressive disclosure.

Reduce repeated "MANDATORY"/"CRITICAL" framing to a single clear statement per requirement to tighten token efficiency.

Consider adding a lightweight validation gate (e.g. a dry-run/preview step) before auto-posting inline PR comments to strengthen the workflow's verification loop.

DimensionReasoningScore

Conciseness

The body is dense and assumes Claude's competence (no explanations of what a PR, hook, or BigNumber is), but repeated "MANDATORY"/"CRITICAL" emphasis and the self-justifying GH-comment rationale add minor padding that could be trimmed.

4 / 5

Actionability

Executable `git diff`/`gh api` commands, a copy-paste report template, concrete scoring anchors, and exact auto-fix diff format provide fully actionable, ready-to-run guidance covering the common review cases.

5 / 5

Workflow Clarity

A clear 10-step sequence with triage, mandatory scoring, and a dedup/merge checkpoint; the inline-comment posting is gated by a threshold filter, though the explicit "post immediately, do not wait" weakens the validation norm slightly.

4 / 5

Progressive Disclosure

Detailed checklists are offloaded to four real, clearly-signaled one-level-deep reference files, while the large inlined report template, scoring system, and priority/confidence tables could arguably live partly in references.

4 / 5

Total

17

/

20

Passed

Description

83%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, specific description anchored to a clear OneKey niche with explicit bilingual trigger guidance. It clearly answers both what the skill does and when to use it, with only minor room to broaden trigger phrasing.

Suggestions

Expand the trigger clause to include natural variations like "review this PR", "审查 diff", or "check my changes" for broader keyword coverage.

Tighten the "when" by naming the triggering context more concretely (e.g. "Use when reviewing a OneKey pull request before merge").

DimensionReasoningScore

Specificity

"Review OneKey PRs and diffs for security, correctness, concurrency, React/RN pitfalls, and repository-specific regressions" lists multiple specific concrete review actions with comprehensive coverage of the review surface.

5 / 5

Completeness

It has a clear "what" (the review dimensions) and an explicit "when" ("Use for code review or 审查 PR"), but the trigger clause could be more specific about scope to fully reach the top anchor.

4 / 5

Trigger Term Quality

"Use for code review or 审查 PR" supplies natural trigger terms in both English and Chinese, but a few common phrasings (e.g. "review this PR", "review my diff") are missing.

4 / 5

Distinctiveness Conflict Risk

The "OneKey" niche, "React/RN pitfalls", and "repository-specific regressions" framing make it clearly distinguishable with minimal overlap risk against generic review skills.

5 / 5

Total

18

/

20

Passed

Validation

93%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation15 / 16 Passed

Validation for skill structure

CriteriaDescriptionResult

allowed_tools_field

'allowed-tools' contains unusual tool name(s)

Warning

Total

15

/

16

Passed

Repository
OneKeyHQ/app-monorepo
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.