Content
75%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-constructed skill body: a five-step build workflow with a test checkpoint, concrete copy-paste-ready code for both activity kinds and the driver, exact file-naming conventions, and a genuine, well-scoped one-level reference file. The main gaps are minor: a slightly incomplete event code sample, no error-recovery guidance in the test step, and duplication between the Quick Reference section and references/activities.md.
Suggestions
Complete the SignalEvent example (or note it reuses LogTask's constructor) so it compiles standalone — it references `S` and `_expressionEvaluator` that are only declared in the task example, and replace the `// ... do work ...` placeholder with a real one-line implementation.
Add a minimal Razor snippet (or point to a repo example file) for one of the three shape templates in Step 3, since currently only filenames are given with no template content.
Trim the Quick Reference's duplicated material (persisting-properties pattern, outcome helpers, WorkflowExecutionContext tables) into pointers to references/activities.md, and add a brief error-recovery note to Step 5 (e.g. what to check if the build fails or the activity doesn't appear in the picker).
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and efficient — tables and compact code instead of prose, and explanations are project-specific facts (e.g. "'EventActivity.Execute' returns 'Halt()' by default — the workflow persists and waits") rather than general knowledge Claude already has. Not 5: the Quick Reference section repeats material already in references/activities.md (the GetProperty/SetProperty pattern, outcome helpers, and WorkflowExecutionContext tables all appear in both), which could be trimmed to pointers. Not 3: there is no padding or over-explanation. | 4 / 5 |
Actionability | Concrete, near-executable guidance throughout: full task class, display driver with EditActivity/UpdateActivity mapping, exact shape template filenames ('LogTask_Fields_Thumbnail.cshtml'), and the registration call `services.AddActivity<LogTask, LogTaskDisplayDriver>()`. Not 5: the event example uses `S` and `_expressionEvaluator` without showing its constructor (defined only in the task example), the task's ExecuteAsync contains a '// ... do work ...' placeholder, and the shape-templates step gives filenames but no template content or Razor example. | 4 / 5 |
Workflow Clarity | A clear five-step sequence (activity class → display driver → shape templates → registration → test) with a validation checkpoint in Step 5: 'Build, open Admin → Workflows, create a workflow, drop your activity, wire its outcome, run.' Not 5: there is no error-recovery feedback loop (e.g. what to check when the build fails or the activity doesn't appear in the picker); not 3 because the sequence is complete, correctly ordered, and ends with an explicit test-and-verify step including the event resume path. | 4 / 5 |
Progressive Disclosure | Good structure: the body is a working overview with a clearly signaled one-level-deep reference — 'references/activities.md — base classes, state, outcomes, expression evaluation, full examples' — which exists and matches its advertised scope, plus pointers to repo docs. Not 5: a noticeable share of the body's Quick Reference and Gotchas content duplicates activities.md verbatim in spirit, so the split is not as clean as it could be; not 3 because references are prominent, shallow, and the core file organization is sound. | 4 / 5 |
Total | 16 / 20 Passed |