CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

review-hog-perspective-logic-correctness

The Logic & Correctness review perspective for PostHog Review. Verifies that changed code does what it is supposed to do: business logic, edge cases, data transformations, and query / data-access correctness. Reports correctness issues only; security and performance are separate perspectives.

56

Quality

70%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

—

The risk profile of this skill

Fix and improve this skill with Tessl

tessl review fix ./products/review_hog/skills/review-hog-perspective-logic-correctness/SKILL.md
SKILL.md
Quality
Evals
Security

Quality

Content

61%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is actionable and well-structured with concrete investigation commands, but it repeats focus areas across three sections and lacks an explicit validate-before-report workflow checkpoint.

Suggestions

Collapse the redundancy between 'Primary investigation areas', 'Key questions', and 'What a valid finding looks like' into a single consolidated checklist to improve token efficiency.

Add an explicit step instructing the reviewer to confirm each candidate finding is reproducible and not a false positive before reporting it.

Provide a short example of the expected finding format so reports are consistent and copy-paste ready.

DimensionReasoningScore

Conciseness

The body is mostly lean and free of concept over-explanation, but 'Primary investigation areas', 'Key questions', and 'What a valid finding looks like' largely restate the same focus areas and could be tightened.

3 / 5

Actionability

Provides concrete, copy-paste-ready ripgrep commands with flags and specific per-area checklists, with only minor gaps (no example of how to structure a reported finding).

4 / 5

Workflow Clarity

Investigation areas are enumerated but there is no explicit sequenced workflow (investigate -> confirm -> report) and no validation checkpoint for confirming a finding is real before reporting.

3 / 5

Progressive Disclosure

A single self-contained file with clear, well-organized section headers and no nested references; at ~89 lines it is slightly long for one file but appropriately structured.

4 / 5

Total

14

/

20

Passed

Description

66%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific and well-scoped against sibling perspectives, with good natural keyword coverage. Its main weakness is the absence of an explicit 'Use when...' trigger clause, which caps completeness.

Suggestions

Add an explicit 'Use when...' clause stating when Claude should select this perspective (e.g., 'Use when reviewing a PR for logic and correctness issues').

Include a few more natural trigger synonyms users might say, such as 'bug', 'off-by-one', or 'broken logic', to broaden trigger-term coverage toward a 5.

DimensionReasoningScore

Specificity

Names the domain and lists several concrete verification areas — 'business logic, edge cases, data transformations, and query / data-access correctness' — with only minor coverage gaps.

4 / 5

Completeness

It clearly states what the perspective does ('Verifies that changed code does what it is supposed to do') but offers no explicit 'Use when...' trigger clause, so completeness is capped at 3 per the rubric guideline.

3 / 5

Trigger Term Quality

Includes natural review vocabulary a developer would say — 'logic', 'correctness', 'business logic', 'edge cases', 'data transformations' — with only a few common synonyms missing.

4 / 5

Distinctiveness Conflict Risk

The niche is clearly scoped — 'Reports correctness issues only; security and performance are separate perspectives' — distinguishing it from sibling perspectives with only minor overlap risk against a general code-review skill.

4 / 5

Total

15

/

20

Passed

Validation

93%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 15 / 16 Passed

Validation for skill structure

CriteriaDescriptionResult

metadata_version

'metadata.version' is missing

Warning

Total

15

/

16

Passed

Repository

PostHog/posthog

Path

products/review_hog/skills/review-hog-perspective-logic-correctness/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.