routing-patterns

Review, generate, and update Rails routes following professional patterns and best practices. Covers RESTful resource routing, route concerns for code reusability, shallow nesting strategies, and advanced route configurations.

Quality

70%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./skills/routing-patterns/SKILL.md

Quality

Content

63%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable, with complete executable Ruby examples and clearly sequenced review/generate/update workflows backed by a checklist and verification commands. Its weaknesses are verbosity — it re-teaches standard Rails routing and carries padded benefit lists and a low-value pattern catalog — and a monolithic single-file structure with no reference files despite being ~600 lines.

Suggestions

Cut or compress sections 4–9 and 11–13 to the app-specific deltas only (e.g. keep only the project's only/except conventions, drop the Rails-manual explanations of singular resources, collection/member routes, and param:); Claude already knows standard Rails routing.

Delete the "Common Routing Patterns" catalog and the "Benefits:" lists — they restate what the preceding code examples already show.

Move advanced material (route resolvers, session routes, engine mounting with constraints, conditional mounting) into a reference file and keep SKILL.md as the overview, cutting the body roughly in half.

Dimension	Reasoning	Score
Conciseness	Noticeably verbose: sections 4–9 and 11–13 re-explain standard Rails knowledge Claude already has ("Singular resources don't have an index action", "Collection routes (no :id needed)"), and padded sections add nothing — the "Benefits:" lists and the entire vague "Common Routing Patterns" catalog ("Pattern: Resources that can have comments / Applied to: Articles, blog posts, products"). Not score 1 because the app-specific material (parent_resource.name.classify concerns, the shallow member-route *_type caveat, turbo_form/rolemodel_rails dependencies) is genuinely non-obvious.	2 / 5
Actionability	Fully executable throughout: complete Ruby concern definitions, a working shallow-override example (param: :kind, shallow: false), mounted-engine constraint lambdas, a fully annotated routes.rb, and copy-paste verification commands (rails routes -c products). The common cases are all covered with runnable code, matching anchor 5.	5 / 5
Workflow Clarity	Three clearly sequenced numbered workflows (review/generate/update) plus a review checklist and a Testing Routes section with explicit verification commands. It falls short of anchor 5 because the validate→fix→retry loop sits in a separate trailing section rather than being embedded as checkpoints inside each workflow, and the update workflow ends with no verification step.	4 / 5
Progressive Disclosure	No bundle files exist, so everything — including a vague pattern catalog, advanced patterns, and session/health-check boilerplate that plainly belongs in reference files — is inlined in one ~600-line document. Section headers are well organized and cross-skill references (polymorphic-parent-resources, dynamic-forms) are clearly signaled, which lifts it above anchor 2, but the absence of any split content holds it at anchor 3.	3 / 5
	Total	14 / 20 Passed

Description

66%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description states its capabilities concretely and occupies a distinct Rails-routing niche. Its main weakness is the missing "Use when" clause — trigger guidance is relegated to a metadata.triggers field instead of the description — which caps completeness and slightly weakens trigger-term quality.

Suggestions

Append a trigger clause to the description itself, e.g. "Use when editing config/routes.rb, adding nested resources or route concerns, or reviewing routes output" — the trigger terms currently live only in metadata.triggers.

Replace the vague tail "advanced route configurations" with the concrete advanced topics actually covered (custom route resolvers, param overrides, constrained engine mounts).

Add natural synonyms/extensions users would say, such as "routes.rb" and "nested routes", to the description text.

Dimension	Reasoning	Score
Specificity	Names three concrete actions ("Review, generate, and update Rails routes") plus specific subtopics ("RESTful resource routing, route concerns for code reusability, shallow nesting strategies"), matching anchor 4; "advanced route configurations" is a vague tail that keeps it from comprehensive anchor-5 coverage.	4 / 5
Completeness	The "what" is clear and concrete, but the description contains no "Use when..." clause or equivalent trigger guidance; per the guideline this caps completeness at 3. The "when" intent lives in a separate metadata.triggers field rather than the description.	3 / 5
Trigger Term Quality	"Rails routes", "route concerns", "shallow nesting", and "RESTful resource routing" are natural user phrases, but common variations like "routes.rb", "nested routes", and "route helper" appear only in metadata.triggers, not in the description itself — good coverage with a few natural terms missing (anchor 4).	4 / 5
Distinctiveness Conflict Risk	"Rails routes" carves a clear niche with distinct trigger vocabulary, giving only minor overlap risk with adjacent Rails skills; the generic "professional patterns and best practices" phrasing is the small collision risk that keeps it below anchor 5.	4 / 5
	Total	15 / 20 Passed

Validation

87%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 14 / 16 Passed

Validation for skill structure

Criteria	Description	Result
skill_md_line_count	SKILL.md is long (615 lines); consider splitting into references/ and linking	Warning
metadata_version	'metadata.version' is missing	Warning

	Total	14 / 16 Passed

Repository: RoleModel/rolemodel-skills
Path: skills/routing-patterns/SKILL.md
Commit: cb80143

Reviewed: 6 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.