CtrlK
BlogDocsLog inGet started
Tessl Logo

design-patterns

在 BK-CI 中判断何时使用工厂、策略、责任链、观察者、模板方法、装饰器等设计模式时使用。当用户要重构可扩展结构、统一模式选型、理解项目里的模式落点时优先使用。

57

Quality

72%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./ai/skills/design-patterns/SKILL.md
SKILL.md
Quality
Evals
Security

Quality

Content

60%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A concise, well-organized selection guide with a clear decision procedure and useful project-specific heuristics. Its critical flaw is that every detailed reference file it relies on is missing from the bundle, breaking both the actionability of the guidance and the progressive-disclosure structure.

Suggestions

Ship the three referenced files (core patterns, selection guidelines, project examples) in a references/ directory — or remove the pointers — since 'reference/1-core-patterns.md', 'reference/2-selection-guidelines.md', and 'reference/3-project-examples.md' currently do not exist.

Use a consistent directory name ('references/' per bundle convention) and make paths resolvable so the pointers in 快速指导 and 延伸阅读 land on real files.

Inline one or two short, concrete BK-CI examples (e.g., a real chain-of-responsibility or factory landing point) so the skill retains actionable guidance even if a reference file is unavailable.

Add a final verification step to the workflow, such as cross-checking the chosen pattern against an existing example in 'reference/3-project-examples.md' before recommending it.

DimensionReasoningScore

Conciseness

The body is lean (~50 lines), never explains what design patterns are, and focuses on project-specific judgment rules ('模式选择要优先服从模块边界 + 扩展点稳定性', '如果只是 2 到 3 个稳定分支...先别急着上复杂模式'). Minor over-explanation appears in 高信号规则, which partially restates textbook knowledge Claude already has ('工厂模式适合如何创建,策略模式适合如何选择一种行为'). Not 5 because of that minor textbook restatement; not 3 because there is no real padding.

4 / 5

Actionability

The 快速指导 section gives a genuine decision procedure (classify problem type → check module boundaries → avoid over-engineering small branches → check existing implementations), which is concrete for an instruction-only skill. However, all three detail files it points to ('reference/1-core-patterns.md', 'reference/2-selection-guidelines.md', 'reference/3-project-examples.md') do not exist in the bundle — the primary actionable pointers are dangling. Not 4 because missing key detail files leave the guidance incomplete; not 2 because the inline decision tree itself is specific and executable.

3 / 5

Workflow Clarity

快速指导 presents a coherent five-step selection sequence with a clear ordering (problem classification → constraint check → complexity threshold → extension preference → check existing project examples), and 不适用场景 provides explicit disqualification criteria. No validation checkpoints exist, but this is an advisory selection skill, not a destructive or batch operation, so the cap does not apply. Not 5 because there is no explicit verification step (e.g., confirming the chosen pattern matches an existing project example) before recommending.

4 / 5

Progressive Disclosure

References are clearly labeled and one level deep in 延伸阅读, but none of the three referenced files ('reference/1-core-patterns.md', 'reference/2-selection-guidelines.md', 'reference/3-project-examples.md') exist — the bundle contains only SKILL.md, with no reference/ or references/ directory. The body is otherwise well-organized and short, but its core progressive-disclosure structure is broken: navigation leads nowhere. Not 3 because broken references are a worse navigation failure than unclearly-signaled ones; not 1 because the body itself has clear sections and no nested-reference chains.

2 / 5

Total

13

/

20

Passed

Description

70%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A well-scoped, clearly triggered description with good natural keywords and an explicit use-when clause. Its main weakness is a thin, slightly circular statement of what the skill actually does — it names the patterns and the triggers but only one capability verb.

Suggestions

State the concrete capability up front (e.g., 提供工厂/策略/责任链/观察者/模板方法/装饰器的选型判断与 BK-CI 落地指导) instead of the circular '判断何时使用...时使用' phrasing.

Add one or two common synonyms users might say, such as 解耦、扩展点设计、消除 if-else, to broaden natural trigger coverage.

Briefly indicate the deliverable (a pattern recommendation with rationale vs. reference material) so the 'what' is unambiguous.

DimensionReasoningScore

Specificity

Names the domain (BK-CI design-pattern selection) and six concrete pattern names (工厂、策略、责任链、观察者、模板方法、装饰器), but the only stated action is '判断何时使用' (judge when to use) — a single action rather than several specific capabilities. Not score 4 because it does not list several distinct concrete actions; not score 2 because the domain and triggers are far more concrete than 'Processes PDF files'.

3 / 5

Completeness

Both parts are present: a 'what' (decide when to use which design pattern in BK-CI) and an explicit 'when' ('当用户要重构可扩展结构、统一模式选型、理解项目里的模式落点时优先使用'). The 'when' is explicit with concrete trigger phrases, but the 'what' is thin and somewhat circular ('use when judging when to use...'), so it does not clearly reach the anchor-5 bar of a fully concrete what + when.

4 / 5

Trigger Term Quality

Contains natural terms users would actually say: 重构可扩展结构, 统一模式选型, 理解模式落点, plus all six pattern names. Good coverage but missing common variations such as 代码坏味道, 解耦, or English terms users might mix in. Not 5 because synonym coverage is incomplete; not 3 because far more than 'some relevant keywords' are present.

4 / 5

Distinctiveness Conflict Risk

Scoped tightly to BK-CI and to pattern selection, with distinct triggers — clearly a niche. Minor overlap risk with the sibling skills it names in its own body ('utility-components', 'common-technical-practices') and with general refactoring guidance. Not 5 because adjacent project-practice skills could compete for refactoring-related queries.

4 / 5

Total

15

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository
TencentBlueKing/bk-ci
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.