Content
50%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A concrete, copy-paste-ready Django testing cookbook with excellent configuration and factory examples, but it is roughly 5-10x longer than needed: most of the body is boilerplate test code Claude already knows how to write, the TDD workflow lacks validation checkpoints, and everything is inlined in SKILL.md with no bundle files to offload reference material.
Suggestions
Cut the generic model/view/serializer test suites down to one exemplar per pattern and keep only the project-specific conventions (pytest.ini addopts, test settings tricks, factory base classes) — this would cut the body by well over half.
Add explicit validation steps to the Red-Green-Refactor cycle: 'run `pytest tests/test_x.py` and confirm it fails (RED)' before implementing, and 'run pytest again and confirm green' before refactoring.
Split the detailed per-domain material (factory definitions, DRF API testing patterns, mocking recipes, coverage goals) into references/ files (e.g. references/factories.md, references/drf-testing.md) and keep SKILL.md as a concise overview with clearly signaled one-level-deep links.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body runs ~730 lines, most of it boilerplate test code Claude can already write (generic conftest fixtures, standard model/view/serializer test suites, 'Remember: Tests are documentation. Good tests explain how your code should work.'), and the 'When to Activate' section duplicates the frontmatter description. Only the project-specific conventions (pytest.ini addopts, DisableMigrations trick, factory house style) genuinely add information Claude lacks. | 2 / 5 |
Actionability | Guidance is overwhelmingly concrete and executable: complete pytest.ini, test settings module, conftest.py, and factory definitions. Minor gaps: several examples reference fixtures or symbols never defined in the shown setup (e.g. `category` in test_product_create_post, `order` in test_order_confirmation_email, `TagFactory` in test_product_with_tags, and `patch`/`Order` are used in the integration test without imports). | 4 / 5 |
Workflow Clarity | The Red-Green-Refactor sequence is present but underdeveloped — 'Step 2: GREEN - Make test pass / # Create User model or factory' is a bare comment, and there are no validation checkpoints such as running `pytest` to confirm red then green. Setup ordering (config -> settings -> conftest -> factories) is implied by section order but never stated as an explicit sequence with checkpoints. | 3 / 5 |
Progressive Disclosure | Section headers throughout make the document navigable, but no references/, scripts/, or assets/ files exist — everything is inlined in SKILL.md. Content that clearly belongs in separate files (the full factory library, per-domain test suites like model/view/serializer/DRF testing, the coverage tables) is inline, so the skill functions as a monolithic reference rather than an overview pointing to detailed materials. | 3 / 5 |
Total | 12 / 20 Passed |