Content
82%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A high-quality, pattern-dense reference: nearly all guidance is executable code with sharp opinionated rules (query priority tiers, anti-patterns, RTL-vs-E2E decision boundary) and validation-minded defaults like onUnhandledRequest: 'error'. The main improvements are trimming the TDD section that duplicates a cross-referenced skill and offloading the Examples and coverage-config sections into reference files to shorten the always-loaded body.
Suggestions
Trim or collapse the TDD Workflow section to a pointer to the tdd-workflow skill and its RED/GREEN/REFACTOR recap — Claude already knows this process and it is cross-referenced anyway (lowest dimension: conciseness).
Move the three full example test files in the Examples section into a references/ file (e.g. references/examples.md) and keep one-line signposts in the body, reducing the always-loaded ~420-line body (progressive_disclosure).
Consolidate the workflow guidance into a single sequenced 'write a test' checklist with explicit verify checkpoints (pick runner -> set up MSW -> write failing test with accessible queries -> verify it fails for the right reason -> implement), rather than distributing it across sections (workflow_clarity).
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense with directives and executable code and mostly assumes competence ('Never setTimeout + assertion — flaky', 'Pick one. Do not run RTL + Vitest AND Playwright CT in the same repo'). However, the TDD Workflow section re-explains RED/GREEN/REFACTOR — a process Claude already knows and which is cross-referenced to a separate tdd-workflow skill — so there are minor instances of over-explanation that could be trimmed. This fits 'Efficient; minor instances of over-explanation that could be trimmed' rather than the fully lean anchor. | 4 / 5 |
Actionability | Nearly every section gives copy-paste-ready, complete code: full MSW server setup with lifecycle hooks, userEvent test bodies, renderHook usage with wrapper, jest-axe assertions, a test-utils.tsx, a vitest.config.ts coverage block, and exact CLI commands ('vitest run --coverage', 'jest path/to/file.test.tsx'). Examples cover the common cases end-to-end, matching 'Fully executable; copy-paste ready code or commands; specific examples cover the common cases'. | 5 / 5 |
Workflow Clarity | The TDD Workflow section gives a clear sequenced process with an explicit validation checkpoint — 'Verify it fails for the right reason' — plus a refactor step, and the MSW setup establishes a validate-early feedback loop via 'onUnhandledRequest: "error"' so unmocked requests fail loudly. This matches 'Clear sequence with most checkpoints present; minor validation gaps'; it is not a fragile multi-step operation skill, so the destructive-operation cap does not apply, but the workflow guidance is secondary to the pattern catalog, keeping it below the explicit-loop anchor. | 4 / 5 |
Progressive Disclosure | No bundle files exist (no references/, scripts/, or assets/), so the skill is a single ~420-line file. Section headers are clear and consistent, cross-links are well-signaled one level deep ('Cross-link: [skills/accessibility/SKILL.md]', 'See [e2e-testing skill](../e2e-testing/SKILL.md)', plus a Related section), and the decision-boundary guidance points onward appropriately. The gap keeping it below 5: all content is inlined in one long SKILL.md — the Examples section (three full test files) and coverage-config block are natural candidates for a references file, fitting 'Good structure; most content is appropriately placed; references mostly clear; minor organization gaps'. | 4 / 5 |
Total | 17 / 20 Passed |