Content
70%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A highly actionable, well-sequenced contribution workflow with strong validation gates and a correctly used bundled PR-body generator. Its weaknesses are length and duplication — the inline shell source-sync library and the redundant PR body template inflate the body and belong in the bundle rather than SKILL.md.
Suggestions
Move the valid_source_checkout / recover_corrupt_source_checkout / sync_latest_source shell functions into a bundled script (e.g. scripts/sync-sources.sh) and invoke it in one line from the workflow to cut ~45 lines from the body.
Delete the 'PR Body Template' section or reduce it to one line pointing at scripts/create-pr-body.mjs — the script already emits that exact structure, so the duplication costs tokens and risks drift if the script changes.
Tighten step 3's prose (routing rules are already stated in the opening section) and resolve the '<skill-root>' placeholder into a concrete relative path so the script invocation is copy-paste ready.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and command-first with no concept explanations Claude already knows, but it runs ~270 lines and repeats itself: the 'PR Body Template' section duplicates the exact structure the bundled create-pr-body.mjs emits, and a ~45-line shell library (valid_source_checkout, recover_corrupt_source_checkout, sync_latest_source) is inlined. Mostly efficient but could be tightened — matches anchor 3 rather than 4. | 3 / 5 |
Actionability | Guidance is overwhelmingly executable: complete bash blocks for clone/worktree/branch, commit, label handling, fork-and-PR and issue creation, plus a concrete JSON input shape for the real bundled script. Not a 5: placeholders like '<short-slug>' and '<skill-root>' require the reader to resolve paths, and the non-gh git fallbacks are only sketched once. | 4 / 5 |
Workflow Clarity | Thirteen explicitly numbered steps with validation checkpoints throughout: reproduce before fixing, a failing regression test confirmed to fail for the right reason, post-fix verification, 'Inspect the status first so the delivered diff cannot be empty or stale', corrupt-checkout quarantine before reuse, and a Stop Conditions section with error-recovery guidance. This is the anchor-5 pattern (validate → fix → retry, explicit gating). | 5 / 5 |
Progressive Disclosure | The single bundled file (scripts/create-pr-body.mjs) is real, correctly referenced, and one level deep — but scored against the actual bundle, the body inlines a ~45-line shell sync library and a full duplicate PR-body template that clearly belong in a bundled script/reference file. Structure exists (clear section headers) but content that should be separate is inline, matching anchor 3. | 3 / 5 |
Total | 15 / 20 Passed |