control-api-tests

Instructions for writing unit tests for new public APIs on WinForms controls and components. Covers test project structure, naming conventions, property tests, event tests, OnXxx method tests, SubControl patterns, data attributes, and handle-state verification.

Quality

82%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Quality

Content

85%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A highly actionable, well-validated reference whose body is dense with executable templates and repo-specific pitfalls. Its main weakness is structure: the test-category template catalog is inlined in SKILL.md rather than split into reference files for progressive disclosure.

Suggestions

Move the detailed test-category templates (sections 6-8) into a references file such as test-templates.md, keeping a summary and one worked example inline in SKILL.md.

Tighten section 6.4's commented step-by-step sequence to a single canonical template; the repeated set-same-value patterns can be stated as one rule instead of three code blocks worth of comments.

Clarify where helper types like CommandViewModel come from (which test helper file), since section 8's example is not executable without that context.

Dimension	Reasoning	Score
Conciseness	Nearly all content is repo-specific, non-obvious knowledge (STA-aware attributes, CA2016/CS8632 CI-only errors, SubControl pattern) with no general-concept padding, though sections like 6.4's extended commented sequences and 8's full command-binding lifecycle could be trimmed.	4 / 5
Actionability	Fully executable C# templates with exact file paths, a concrete naming grammar, attribute tables, and per-category test examples covering all common cases (default values, round-trips with and without handle, event idempotency, unsubscribe, OnXxx via SubControl).	5 / 5
Workflow Clarity	Clear sequence (locate file → name test → required categories → checklist) with explicit validation checkpoints: embedded Assert.False(control.IsHandleCreated) assertions, the "Verify with build.cmd (CI parity)" step with its failure mode explained, and a final checklist in section 9.	5 / 5
Progressive Disclosure	No bundle files exist and the 430-line body inlines ~250 lines of per-category test templates (sections 6-8) that belong in a one-level-deep references file; sections are well-organized and cross-skill pointers are clear, but everything lives in SKILL.md.	3 / 5
	Total	17 / 20 Passed

Description

71%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A specific, comprehensive description of what the skill covers, weakened only by the absence of any "Use when" trigger clause and some missing natural keyword variations. It is clearly distinguishable from related skills.

Suggestions

Append an explicit trigger clause, e.g. "Use when adding new public properties, methods, or events to a WinForms control or component and tests are required."

Add natural trigger keywords users would say, such as "unit testing", "test coverage", or "xUnit", alongside the existing domain terms.

Clarify the boundary with the sibling skill inline (e.g. mention that the API implementation itself belongs to new-control-api) to reduce overlap risk.

Dimension	Reasoning	Score
Specificity	The description enumerates eight concrete capability areas ("test project structure, naming conventions, property tests, event tests, OnXxx method tests, SubControl patterns, data attributes, and handle-state verification"), comprehensively covering the skill's scope with no gaps.	5 / 5
Completeness	It clearly answers "what" (instructions for writing unit tests for new public APIs) but contains no "Use when..." clause or equivalent trigger guidance, which caps completeness at 3.	3 / 5
Trigger Term Quality	Natural phrases like "writing unit tests", "WinForms controls and components", and "property tests" are present, but common variations users would say ("test coverage", "xUnit", ".NET", "testing") are missing.	4 / 5
Distinctiveness Conflict Risk	Niche domain terms ("OnXxx method tests", "SubControl patterns", "WinForms controls") make it mostly distinct, with only minor overlap risk against generic testing skills and the sibling new-control-api skill.	4 / 5
	Total	16 / 20 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: dotnet/winforms
Path: .github/skills/control-api-tests/SKILL.md
Commit: a84cf1f

Reviewed: 9 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.