new-control-api

Instructions for adding new public APIs (properties, methods, events, delegates) to existing WinForms controls or components. Covers API issue tracking, PublicAPI file maintenance, property/event conventions, CodeDOM serialization, design-time attributes, and XML documentation.

Quality

75%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.github/skills/new-control-api/SKILL.md

Quality

Content

78%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable and well-sequenced with strong validation checkpoints, but it is a monolithic single file with no progressive disclosure via bundle references. Splitting heavy reference material into separate files would improve navigability and token efficiency.

Suggestions

Extract the PublicAPI entry-format reference (Section 2.3) and the experimental-API graduation steps (Section 7.2) into a references/ file, keeping only key examples inline.

Add an explicit validate-fix-retry loop for API tracking (e.g. run build.cmd, if RS0016 errors appear, add the missing PublicAPI lines, re-run) rather than relying on a one-shot CI note.

Move the localization/SR.resx detail (Section 9) into a dedicated reference file and link to it from a brief inline summary.

Dimension	Reasoning	Score
Conciseness	Largely lean and dense with executable code, tables, and targeted rules assuming C#/WinForms knowledge, with only minor over-explanation (e.g. the 'Golden rule' restating the checklist and some PropertyStore rationale) that could be trimmed.	4 / 5
Actionability	Copy-paste-ready C# for property storage, events, EventArgs, and XML docs, plus concrete file paths (PublicAPI.Unshipped.txt, DiagnosticIDs.cs, SR.resx), specific attributes, and throw helpers cover the common cases comprehensively.	5 / 5
Workflow Clarity	Clearly sequenced sections with a pre-submit checklist and validation guidance (RS0016 under build.cmd, 'stop and ask the user' on missing issue info), though it lacks an explicit inline validate-fix-retry feedback loop for API tracking.	4 / 5
Progressive Disclosure	Good internal section structure, but the skill is a single 638-line file with no bundle files (references/, scripts/, assets/) and inline reference material (PublicAPI format, experimental graduation, localization) that could be split into one-level-deep files.	3 / 5
	Total	16 / 20 Passed

Description

71%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific, capability-rich, and clearly niched to WinForms API additions, but it omits an explicit 'Use when...' trigger, leaving the invocation condition only weakly implied. Adding a concrete trigger clause would lift completeness and trigger-term quality.

Suggestions

Append an explicit 'Use when...' clause, e.g. 'Use when adding new public or protected members to an existing WinForms control or component.'

Include a user-facing synonym or two in the trigger (e.g. 'adding a property or event to a control', 'designer serialization') to broaden natural-term coverage.

Briefly state the boundary in the description (e.g. 'For new controls or general standards, see coding-standards') to reinforce distinctiveness without relying on the body.

Dimension	Reasoning	Score
Specificity	Enumerates multiple concrete capabilities — 'adding new public APIs (properties, methods, events, delegates)' plus 'API issue tracking, PublicAPI file maintenance, property/event conventions, CodeDOM serialization, design-time attributes, and XML documentation' — giving comprehensive, specific coverage rather than vague language.	5 / 5
Completeness	It clearly states what the skill does, but there is no explicit 'Use when...' trigger clause; the 'when' is only weakly implied, which per the rubric caps completeness at 3.	3 / 5
Trigger Term Quality	Strong keyword coverage including 'WinForms controls', 'properties, methods, events, delegates', 'PublicAPI file', 'CodeDOM serialization', and 'XML documentation', but it leans technical and omits common user-facing synonyms a developer might naturally phrase.	4 / 5
Distinctiveness Conflict Risk	Scoped to a distinct niche — adding public APIs to existing WinForms controls/components — with minimal overlap risk, though the description itself does not state the boundary against related skills (that contrast lives in the body).	4 / 5
	Total	16 / 20 Passed

Validation

93%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 15 / 16 Passed

Validation for skill structure

Criteria	Description	Result
skill_md_line_count	SKILL.md is long (639 lines); consider splitting into references/ and linking	Warning

	Total	15 / 16 Passed

Repository: dotnet/winforms
Path: .github/skills/new-control-api/SKILL.md
Commit: b0a7c95

Reviewed: 1 day ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.