migrate-frontend-forms

Guide for migrating forms from the legacy JsonForm/FormModel system to the new TanStack-based form system.

Quality

67%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.agents/skills/migrate-frontend-forms/SKILL.md

Quality

Content

77%Weight 40%Scale 1-3

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The content is highly actionable with executable examples and a verification-backed checklist, but it is long and monolithic rather than progressively disclosed. Splitting detailed per-feature examples into reference files would push it into the top band.

Suggestions

Move the lengthy per-feature Old/New examples and the TanStack type-inference rules into one-level-deep reference files (e.g. references/feature-mapping.md, references/tanstack-types.md) and summarize them in SKILL.md.

Trim redundant 'Simpler pattern' and overlapping ❌/✅ type examples to the single most representative case to reduce token cost.

Cross-link the existing external file mention (static/AGENTS.md) more prominently as the canonical TanStack type-inference reference to avoid restating its rules inline.

Dimension	Reasoning	Score
Conciseness	The body is mostly efficient and free of generic concept explanations Claude already knows, but at ~680 lines it carries redundancy (full plus 'Simpler pattern' variants and many overlapping ❌/✅ type-inference examples) that could be tightened without losing clarity.	2 / 3
Actionability	Dozens of concrete, copy-paste-ready Old/New TSX pairs and explicit commands (fetchMutation, setFieldErrors, pnpm run extract-form-fields) give fully executable, specific guidance.	3 / 3
Workflow Clarity	A sequenced Migration Checklist with verification items (run extract-form-fields and commit generatedFieldRegistry.ts, verify onSuccess cache merges) provides explicit checkpoints for a risky migration, satisfying the validation requirement.	3 / 3
Progressive Disclosure	Sections are well-organized, but the ~680-line SKILL.md is monolithic with feature-by-feature reference detail that could live in one-level-deep reference files; no bundle files exist to offload it, matching the 'content that should be separate is inline' anchor.	2 / 3
	Total	10 / 12 Passed

Description

57%Weight 40%Scale 1-3

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific and distinct but lacks a 'Use when' trigger clause and relies on project jargon, capping completeness and trigger quality at 2. Adding natural-language trigger phrasing would lift it to the top band.

Suggestions

Add a 'Use when...' clause stating when to invoke the skill, e.g. 'Use when migrating Sentry settings forms from JsonForm/FormModel to the TanStack form system.'

Include more natural user-facing trigger terms (e.g. 'form migration', 'update legacy form', 'convert JsonForm') alongside the codebase jargon.

List 2-3 concrete migration actions (e.g. convert field config to JSX, rewrite getData/mapFormErrors, wrap with FormSearch) to raise specificity.

Dimension	Reasoning	Score
Specificity	Names the domain and source/target systems ('migrating forms from the legacy JsonForm/FormModel system to the new TanStack-based form system') but lists only one action ('migrating') rather than multiple concrete actions, so it stops at the 'names domain and some actions' anchor.	2 / 3
Completeness	It clearly states what the skill does, but there is no 'Use when...' clause or equivalent trigger guidance, which the rubric caps at 2 for missing explicit 'when' triggers.	2 / 3
Trigger Term Quality	Relevant keywords like 'migrating forms', 'JsonForm/FormModel', and 'TanStack' appear, but these are codebase-specific jargon and common user phrasings (e.g. 'form migration', 'update old form') are not covered, fitting the 'some relevant keywords but missing common variations' anchor.	2 / 3
Distinctiveness Conflict Risk	The narrow pairing of a specific legacy (JsonForm/FormModel) to a specific new (TanStack) system is a clear niche unlikely to trigger for unrelated skills.	3 / 3
	Total	9 / 12 Passed

Validation

87%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 14 / 16 Passed

Validation for skill structure

Criteria	Description	Result
skill_md_line_count	SKILL.md is long (682 lines); consider splitting into references/ and linking	Warning
referenced_paths_exist	Referenced path issues: 1 missing	Warning

	Total	14 / 16 Passed

Repository: getsentry/sentry
Path: .agents/skills/migrate-frontend-forms/SKILL.md
Commit: b4b3565

Reviewed: 2 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.