Content
67%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured, opinionated conventions skill with concrete decision criteria and clear references to the canonical detail doc. Its main weakness is verbosity — persuasive prose and a redundant summary section could be trimmed to respect the token budget.
Suggestions
Trim the rhetorical justification in 'Hooks live at the edge' (e.g. 'discipline fails at the third layer of composition; prevention does not') to the minimal rationale needed to justify the rule, since Claude already understands hook composition.
Drop or fold the 'The short version' section — it restates rules already covered and adds tokens without new guidance; a one-line pointer at the top would preserve scanability.
Add a small concrete code example of the allowed `use-*` adapter shape (useSyncExternalStore/useContext/disposal useEffect wired to the engine) to make the 'three-line wire' instruction copy-paste ready.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly efficient but padded with extended rhetorical justification ('discipline fails at the third layer of composition; prevention does not') and a 'short version' that restates the main rules; some of the prose explains hook composition concepts Claude already knows. | 3 / 5 |
Actionability | Provides concrete, actionable rules — the two acceptable hook situations, an apply/skip list for data-testid, kebab-case value examples, and the extract-to-class instruction — though it lacks a concrete code example of the allowed `use-*` adapter shape. | 4 / 5 |
Workflow Clarity | The decision flow is clear (is the hook load-bearing? if yes, extract to a class/namespace and reduce the hook to a three-line wire) with explicit acceptance criteria, though it is a conventions skill rather than a sequenced multi-step workflow. | 4 / 5 |
Progressive Disclosure | Well-organized into clear sections with a one-level-deep, clearly signaled reference to `docs/contributing/react.md` for the full table and worked examples; the body itself runs somewhat long for an overview but is appropriately split. | 4 / 5 |
Total | 15 / 20 Passed |