122-java-type-design
Use when you need to review, improve, or refactor Java code for type design quality — including establishing clear type hierarchies, applying consistent naming conventions, eliminating primitive obsession with domain-specific value objects, leveraging generic type parameters, creating type-safe wrappers, designing fluent interfaces, ensuring precision-appropriate numeric types (BigDecimal for financial calculations), and improving type contrast through interfaces and method signature alignment. Part of the skills-for-java project
82
77%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./skills/122-java-type-design/SKILL.mdQuality
Discovery
85%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
This is a strong skill description that clearly articulates what it does (Java type design improvements) and when to use it. The specificity is excellent with numerous concrete techniques listed. The main weakness is trigger term quality - while comprehensive for experts, it relies heavily on technical jargon that typical users might not use when requesting help.
Suggestions
Add more natural user-facing trigger terms like 'class design', 'better types', 'type safety', 'wrapper classes', or 'domain modeling' that users would actually say when needing this skill
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Lists multiple specific concrete actions: 'establishing clear type hierarchies', 'applying consistent naming conventions', 'eliminating primitive obsession with domain-specific value objects', 'leveraging generic type parameters', 'creating type-safe wrappers', 'designing fluent interfaces', 'ensuring precision-appropriate numeric types (BigDecimal for financial calculations)', and 'improving type contrast through interfaces'. | 3 / 3 |
Completeness | Explicitly answers both what (review, improve, refactor Java code for type design quality with specific techniques) AND when ('Use when you need to review, improve, or refactor Java code for type design quality'). Has a clear 'Use when...' clause at the beginning. | 3 / 3 |
Trigger Term Quality | Contains some relevant technical terms like 'Java code', 'type design', 'refactor', 'BigDecimal', but uses more specialized jargon ('primitive obsession', 'type contrast', 'fluent interfaces') that users may not naturally say. Missing common variations like 'types', 'typing', 'class design', 'OOP'. | 2 / 3 |
Distinctiveness Conflict Risk | Highly specific niche focused on Java type design quality specifically, with distinct triggers around type hierarchies, value objects, generic parameters, and BigDecimal. Unlikely to conflict with general Java skills or other language skills due to the narrow focus on type system design patterns. | 3 / 3 |
Total | 11 / 12 Passed |
Implementation
70%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This skill has excellent workflow clarity with explicit compilation checkpoints and good progressive disclosure structure. However, it lacks concrete code examples in the main skill file, relying entirely on the reference document for actionable patterns. The overview section is somewhat verbose given that it's essentially a table of contents for the reference file.
Suggestions
Add 1-2 brief, executable code examples showing good vs bad type design patterns directly in the skill (e.g., primitive obsession fix with a value object)
Condense the 'What is covered' bullet list - consider removing items that are self-explanatory to Claude or consolidating related items
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The skill is reasonably efficient but includes some redundancy - the bullet list of covered topics largely repeats information that would be in the reference file, and the 'What is covered' section could be more concise. | 2 / 3 |
Actionability | Provides concrete commands for compilation/verification, but lacks any executable code examples in the skill itself. All actual patterns and examples are deferred to the reference file, making this more of a pointer than actionable guidance. | 2 / 3 |
Workflow Clarity | Clear workflow with explicit validation checkpoints: compile before changes, stop on failure, verify after changes. The MANDATORY/SAFETY/VERIFY structure makes the sequence unambiguous with proper feedback loops. | 3 / 3 |
Progressive Disclosure | Well-structured overview with clear single-level reference to detailed documentation. The skill appropriately serves as an entry point, signaling where to find detailed examples without nesting references. | 3 / 3 |
Total | 10 / 12 Passed |
Validation
100%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 11 / 11 Passed
Validation for skill structure
No warnings or errors.
- Repository
- jabrena/cursor-rules-java
- Commit
7772a1b
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.