122-java-type-design

Use when you need to review, improve, or refactor Java code for type design quality — including establishing clear type hierarchies, applying consistent naming conventions, eliminating primitive obsession with domain-specific value objects, leveraging generic type parameters, creating type-safe wrappers, designing fluent interfaces, ensuring precision-appropriate numeric types (BigDecimal for financial calculations), and improving type contrast through interfaces and method signature alignment. This should trigger for requests such as Review Java code for type design; Improve type design in Java code; Fix primitive obsession in Java code; Create value objects in Java code. Part of cursor-rules-java project

Quality

—

Does it follow best practices?

Impact

—

No eval scenarios have been run

Securityby

Passed

No known issues

Quality

Content

85%

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A well-organized, lean skill body with a clear validated workflow and proper one-level-deep progressive disclosure to a real reference file. Its main weakness is actionability: the actual type-design patterns are entirely deferred to the reference, leaving the in-body refactoring step somewhat abstract.

Suggestions

Add one or two short inline good/bad code examples (e.g., a primitive String email vs. an EmailAddress value object) so the core refactoring pattern is actionable without opening the reference.

Tighten step 3 from 'Implement selected type-safety and readability improvements based on applicable patterns' to a concrete selection criterion for which pattern to apply first.

Dimension	Reasoning	Score
Conciseness	The body is lean — a bulleted coverage list, constraints, a short workflow, and a reference link — with no padding or explanations of concepts Claude already knows; every section earns its place.	3 / 3
Actionability	Build commands ('./mvnw compile', 'mvn clean verify') are concrete and executable, but the core type-design refactorings have no inline examples and step 3 ('Implement selected type-safety and readability improvements based on applicable patterns') is vague, deferring all specifics to the reference.	2 / 3
Workflow Clarity	The 4-step workflow is clearly sequenced with explicit validation checkpoints — compile and stop immediately on failure, then verify with a full build — providing a feedback loop for the risky refactoring operation.	3 / 3
Progressive Disclosure	The SKILL.md is a concise overview that signals one-level-deep navigation to the real file references/122-java-type-design.md (verified to exist), with content appropriately split between overview and reference.	3 / 3
	Total	11 / 12 Passed

Description

90%

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, specific description with explicit triggers and good coverage of natural user phrasings, clearly scoped to Java type design. The main weakness is the second-person voice ('you need'), which the rubric penalizes.

Suggestions

Rewrite the opening in third-person imperative voice (e.g., 'Use when reviewing, improving, or refactoring Java code for type design quality') to avoid the second-person 'you need'.

Drop the trailing 'Part of cursor-rules-java project' metadata, which adds no trigger value for the user.

Dimension	Reasoning	Score
Specificity	The description lists many concrete actions ('establishing clear type hierarchies', 'eliminating primitive obsession with domain-specific value objects', 'BigDecimal for financial calculations'), which would score 3, but it uses second-person voice ('Use when you need to review...'), so specificity is reduced by 1 per the voice guideline.	2 / 3
Completeness	It explicitly answers both what (review/improve/refactor Java type design with a enumerated capabilities) and when ('Use when you need to...' plus explicit trigger request examples), with explicit trigger guidance.	3 / 3
Trigger Term Quality	It gives natural phrasings a user would actually say — 'Review Java code for type design; Improve type design in Java code; Fix primitive obsession in Java code; Create value objects in Java code' — with good coverage of common variations.	3 / 3
Distinctiveness Conflict Risk	The Java type-design niche is clear and specific (value objects, fluent interfaces, primitive obsession, BigDecimal), with distinct triggers unlikely to fire for unrelated skills.	3 / 3
	Total	11 / 12 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: jabrena/cursor-rules-java
Commit: 86eb63d

Reviewed: 4 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.