CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

requesting-code-review

完成任务、实现重要功能或合并前使用,用于验证工作成果是否符合要求

Quality

66%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./skills/requesting-code-review/SKILL.md
SKILL.md
Quality
Evals
Security

Quality

Content

75%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is a tight, actionable orchestration guide: exact git commands, a placeholder-driven dispatch template, a realistic worked example, and explicit feedback-triage rules with red lines. Its main weaknesses are the missing code-reviewer.md template dependency, the un-closed review loop (no re-review after fixes), and some rule duplication between the feedback-handling and red-line sections.

Suggestions

Ship the referenced template in the bundle (e.g. references/code-reviewer.md) or inline its prompt skeleton, since the core dispatch step is unusable without it.

Close the feedback loop: after fixing Critical/Important issues, re-request a review of the fix commits before continuing, rather than proceeding directly to the next task.

Merge the duplicated rules between 处理反馈 and 红线 into a single triage section to remove the repetition of Critical/Important handling and reviewer-rebuttal guidance.

DimensionReasoningScore

Conciseness

The body is lean and instructional with no explanation of concepts Claude already knows; the SHA commands, placeholder table, and worked example all earn their tokens. Minor trim opportunities exist: the Critical/Important fix rules and the rebut-with-technical-reasons guidance each appear twice (in 处理反馈 and again in 红线), and the rationalization table is partly motivational padding. This fits anchor 4 ('efficient; minor instances that could be trimmed'), not 5 (the duplication keeps it from being fully lean) and not 3 (there is no genuinely unnecessary explanation).

4 / 5

Actionability

Concrete, executable guidance throughout: exact shell commands for BASE_SHA/HEAD_SHA, a defined placeholder schema ({DESCRIPTION}, {PLAN_OR_REQUIREMENTS}, {BASE_SHA}, {HEAD_SHA}), explicit feedback triage rules, and a filled-in worked example. The gap keeping it from anchor 5 is that the core dispatch step depends entirely on the code-reviewer.md template, which is referenced but not present in the bundle, so the prompt cannot be copy-paste assembled from this skill alone.

4 / 5

Workflow Clarity

The three-step sequence (get SHAs → dispatch reviewer → triage feedback) is clearly numbered with executable commands, explicit checkpoints (Important issues must be fixed before continuing), and error-recovery handling for a mistaken reviewer. It falls short of anchor 5 because the loop is not closed: after fixing Critical/Important issues the skill proceeds directly to the next task (as the example shows) without a re-review checkpoint to confirm the fixes. No destructive/batch operation is involved, so the workflow cap does not apply.

4 / 5

Progressive Disclosure

A single well-organized file with clear sections (when / how / example / red lines) and one clearly signaled, one-level-deep reference ("参见模板:requesting-code-review/code-reviewer.md") — matching anchor 4 ('good structure; references mostly clear; minor organization gaps'). It does not reach 5 because the referenced template file does not exist in the bundle (no references/ directory), leaving the pointer dangling rather than resolving to actual content.

4 / 5

Total

16

/

20

Passed

Description

45%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description answers 'when' clearly but leaves 'what' almost entirely unstated: it never mentions code review, the review subagent, or diff inspection, which are the skill's entire purpose. This weakens trigger matching (a user saying 'review this code' won't surface it) and makes it confusable with generic verification/testing skills.

Suggestions

State the concrete mechanism instead of the abstract goal, e.g. "派遣代码审查子代理审查 BASE_SHA..HEAD_SHA 的 diff,返回优点/问题/评估" (dispatch a code-review subagent over the commit range and return strengths/issues/verdict).

Add the natural trigger terms users would actually say — "代码审查", "review", "审查代码", "检查工作成果" — so the skill surfaces when someone explicitly asks for a review.

Name the skill's concrete outputs (prioritized Critical/Important/Minor issue report) so the 'what' is explicit rather than implied by the 'when' clause.

DimensionReasoningScore

Specificity

The only action stated is the generic "验证工作成果是否符合要求" (verify work output meets requirements), which names a domain but offers no concrete actions — it never mentions dispatching a review subagent, reviewing a diff, or any mechanism. It fits anchor 2 ('names the domain but actions are minimal or generic'), not 3 (which requires 1-2 concrete actions) and not 1 (a domain and an action are present).

2 / 5

Completeness

The 'when' is explicit (after task completion, after major features, before merge), but the 'what' is vague — "验证工作成果是否符合要求" says nothing about what the skill actually does (dispatch a code-review subagent with BASE_SHA/HEAD_SHA over a diff). Anchor 4 requires a real 'what' alongside the 'when'; anchor 2 is ruled out because a 'when' clause is present, leaving 3.

3 / 5

Trigger Term Quality

Trigger phrases "完成任务" (task completion), "实现重要功能" (implementing features), and "合并前" (before merge) are semi-natural, but the most obvious user phrases — "代码审查", "review", "审查代码" — are entirely absent, so a user asking for a code review would not naturally trigger this skill. This matches anchor 3 ('some relevant keywords but missing common variations or synonyms'), not 4 (good coverage) and not 2 (more than two relevant keywords exist).

3 / 5

Distinctiveness Conflict Risk

The pre-merge/task-completion framing ties it to development workflows, but "验证工作成果是否符合要求" (verify work output meets requirements) could equally describe testing, QA, or validation skills, giving moderate overlap risk. It is more specific than anchor 2 ('helps with document files' level breadth) but less distinct than anchor 4, which would require naming the concrete review mechanism.

3 / 5

Total

11

/

20

Passed

Validation

81%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 13 / 16 Passed

Validation for skill structure

CriteriaDescriptionResult

metadata_version

'metadata.version' is missing

Warning

metadata_field

'metadata' should map string keys to string values

Warning

frontmatter_unknown_keys

Unknown frontmatter key(s) found; consider removing or moving to metadata

Warning

Total

13

/

16

Passed

Repository

jnMetaCode/superpowers-zh

Path

skills/requesting-code-review/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.