testing-anti-patterns

Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code - prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies

Quality

75%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.agency/plugins/nori/skills/testing-anti-patterns/SKILL.md

Quality

Content

75%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A highly actionable, well-structured catalog of testing anti-patterns with concrete code and decision-gate checkpoints. Its main weakness is redundancy across summary sections, and it is somewhat long for a single-file skill.

Suggestions

Collapse the restated principle in 'The Bottom Line', 'Overview', and 'Iron Laws' into a single canonical statement to remove repetition and save tokens.

Consider moving the per-anti-pattern gate functions or the Quick Reference into a separate reference file so SKILL.md stays a lean overview.

Dimension	Reasoning	Score
Conciseness	Content is actionable and assumes Claude's competence, but the core principle ('test real behavior, not mock behavior') is restated across the Overview, Iron Laws, Bottom Line, Quick Reference, and Red Flags sections, adding noticeable repetition that could be tightened.	3 / 5
Actionability	Each anti-pattern pairs a concrete 'BAD' TypeScript snippet with a 'GOOD' fix and an executable IF/STOP gate function, giving copy-paste-ready guidance that covers the common cases.	5 / 5
Workflow Clarity	The per-anti-pattern gate functions provide explicit decision checkpoints and STOP conditions with clear sequencing, though there is no single overarching multi-step workflow tying the checks together.	4 / 5
Progressive Disclosure	The single file is well-organized with clear section headers, a Quick Reference table, and Red Flags list for easy navigation; with no bundle files present and no external references needed, structure is good, though the 300+ line catalog could justify splitting detail into a reference file.	4 / 5
	Total	16 / 20 Passed

Description

75%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

A strong, specific description with explicit 'Use when' trigger guidance and concrete preventions. It clearly communicates both scope and applicability, with only minor gaps in synonym coverage and a slightly indirect framing of the 'what'.

Suggestions

Reframe the 'what' as active capabilities (e.g., 'Flags and corrects testing anti-patterns: mock-behavior assertions, test-only production methods, and unexamined mock dependencies') so the skill's actions are stated directly rather than as preventions.

Add common synonyms such as 'unit tests', 'stubs', or 'test doubles' to broaden trigger term coverage.

Dimension	Reasoning	Score
Specificity	Names the testing domain and several concrete items ('writing or changing tests, adding mocks, or tempted to add test-only methods to production code'; 'prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies'), but the 'what' is framed as preventions rather than a list of distinct actions.	4 / 5
Completeness	Explicitly answers both 'when' ('Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code') and 'what' ('prevents testing mock behavior, production pollution...'), but the 'what' is expressed as preventions rather than direct capabilities, keeping it just below a 5.	4 / 5
Trigger Term Quality	Includes natural phrases a user would say ('writing or changing tests', 'adding mocks', 'test-only methods') with good coverage, though a few common synonyms like 'unit tests', 'stubs', or 'test doubles' are missing.	4 / 5
Distinctiveness Conflict Risk	Has a clear niche around testing anti-patterns and mock misuse with minimal conflict risk, though the broad 'writing or changing tests' trigger creates minor overlap with general testing skills.	4 / 5
	Total	16 / 20 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: microsoft/FluidFramework
Path: .agency/plugins/nori/skills/testing-anti-patterns/SKILL.md
Commit: f02e424

Reviewed: 3 days ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.