testing-anti-patterns

Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code - prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies

Quality

92%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide

Securityby

Passed

No findings from the security scan

Quality

Content

85%

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is highly actionable with concrete BAD/GOOD code pairs and explicit gate-function validation checkpoints for each anti-pattern. Its main weakness is conciseness: the same guidance is restated across several summary sections that could be consolidated.

Suggestions

Consolidate the redundant summary sections ('The Iron Laws', 'Quick Reference' table, 'Red Flags', 'The Bottom Line') into a single concise reference to cut repetition and token cost.

Drop or compress narration of concepts Claude already knows, e.g. 'Mocks are a means to isolate, not the thing being tested' which restates the Overview line.

Tighten the 'TDD Prevents These Anti-Patterns' section, since its points already appear in the Overview and individual anti-pattern fixes.

Dimension	Reasoning	Score
Conciseness	The content is mostly efficient and adds value Claude lacks (specific anti-patterns and gate functions), but it restates the same ideas across 'The Iron Laws', 'Quick Reference', 'Red Flags', 'The Bottom Line', and 'TDD Prevents These Anti-Patterns', so it could be tightened. It does not fall to 1 because the core material is genuinely non-obvious guidance rather than filler.	2 / 3
Actionability	Each anti-pattern pairs a concrete BAD TypeScript snippet with a concrete GOOD fix, plus specific decision procedures, giving copy-paste-ready executable examples. It is above 2 because the guidance is concrete and specific rather than pseudocode-only abstraction.	3 / 3
Workflow Clarity	Every anti-pattern includes a 'Gate Function' that is an explicit validation checkpoint ('BEFORE asserting... Ask... IF... STOP'), and the mocking section adds a feedback loop (run with real implementation first, observe, then mock minimally). This matches the 'clear sequence with explicit validation steps' anchor.	3 / 3
Progressive Disclosure	The skill is a single self-contained SKILL.md with no bundle files and no nested references, organized into clearly labeled sections (Overview, anti-patterns, Quick Reference, Red Flags). With nothing to offload and clean sectioning, navigation is easy and there are no dead or deeply-nested references.	3 / 3
	Total	11 / 12 Passed

Description

100%

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is specific, uses natural trigger terms, and explicitly covers both what the skill does and when to use it, with a clear niche unlikely to conflict with other skills. Its only weakness is that it crams everything into one long run-on sentence rather than a tighter formulation.

Dimension	Reasoning	Score
Specificity	Lists multiple concrete actions ('writing or changing tests, adding mocks, or tempted to add test-only methods to production code') plus concrete prevented behaviors, matching the 'multiple specific concrete actions' anchor.	3 / 3
Completeness	Explicitly answers both what it does ('prevents testing mock behavior, production pollution... and mocking without understanding dependencies') and when to use it ('Use when writing or changing tests, adding mocks...').	3 / 3
Trigger Term Quality	Uses natural phrases a user would actually say — 'writing or changing tests', 'adding mocks', 'test-only methods' — giving good coverage of natural trigger terms rather than jargon.	3 / 3
Distinctiveness Conflict Risk	Occupies a clear niche (test/mock anti-patterns) with distinct triggers unlikely to fire for unrelated skills, matching the 'clear niche with distinct triggers' anchor.	3 / 3
	Total	12 / 12 Passed

Validation

100%

Warnings & errors only

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository: microsoft/FluidFramework
Path: .agency/plugins/nori/skills/testing-anti-patterns/SKILL.md
Commit: f9f2007

Reviewed: about 7 hours ago

Table of Contents

Discovery Implementation Validation

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.