Content
88%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A strong, highly actionable body: exact commands, executable code skeletons, explicit gates, and a genuine troubleshooting playbook keyed to real failure modes. The main weaknesses are minor redundancy (the pdk-test boundary and INIT_SLEEP gotcha are each stated twice or more) and template references that point outside the bundle without stating where the templates live.
Suggestions
State once where the `templates/*.rs` files live (e.g., 'in the `pdk-templates` sibling skill') at their first mention, since they are not part of this skill's bundle and the current bare paths cannot be resolved from SKILL.md alone.
Consolidate the three unit-vs-integration discussions ('When to use this skill vs alternatives', Step 1, and 'When to graduate to `pdk-test`') into one section and cross-reference it, reclaiming roughly 15 lines.
Cover the INIT_SLEEP gotcha in one place only (Step 5) and have the Troubleshooting entry reference `INIT_SLEEP` from `src/tests/common.rs` rather than restating the full cause/fix.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and assumes competence (no explanation of Rust, cargo, or what unit testing is), but the unit-vs-`pdk-test` distinction is explained three times ("When to use this skill vs alternatives", Step 1's decision tree, and "When to graduate to `pdk-test`") and the `INIT_SLEEP` gotcha is fully repeated in both Step 5 and Troubleshooting. Fits the 4 anchor ("minor instances of over-explanation that could be trimmed"); not 5 because of this redundancy, not 3 because there is no padded conceptual explanation. | 4 / 5 |
Actionability | Everything is copy-paste executable: exact commands (`mkdir -p src/tests`, `cargo test hello_world -- --nocapture`, `make test`), a concrete `UnitTestBuilder` skeleton, exact error strings ("no upstream registered for authority X") with diagnostic steps (`info!("calling {:?}", &config.service);`) and specific fixes. Matches the 5 anchor; not 4 because even edge cases (entrypoint naming, timer advancement) get executable fixes. | 5 / 5 |
Workflow Clarity | A clearly sequenced Step 1–5 workflow with an explicit validation gate ("this test must pass before adding mocks, advanced config, or violations. If it fails, jump to Troubleshooting") and a cause/fix Troubleshooting section that provides feedback loops for every named failure mode. Matches the 5 anchor (explicit validation steps, error-recovery loops, plus a Pattern Index checklist); not 4 because checkpoints are explicit and no risky step lacks a verify-then-proceed condition. | 5 / 5 |
Progressive Disclosure | Good structure: lean overview sections, a Pattern Index table, and a well-signaled one-level-deep pointer for the full API ("lives in `pdk-templates/templates/unit_testing.md`... Do not re-derive"). Falls short of 5 because the seven referenced `templates/*.rs` files (e.g., `templates/hello_test.rs`) are not present in this skill's bundle — no references/, scripts/, or assets/ directories exist — so their location is only implied; not 3 because the references that do exist are clearly signaled and the split between inline essentials and external detail is sound. | 4 / 5 |
Total | 18 / 20 Passed |