Content
82%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured, highly actionable skill body: nearly every step is a concrete executable command, workflows are clearly sequenced with ordering rationale and a permission-failure fallback, and troubleshooting covers real error messages. Minor improvements are possible: the opening line duplicates the description, Key Points repeats Overview facts, and the multi-PR workflow lacks explicit verification checkpoints.
Suggestions
Remove the opening paragraph that restates the frontmatter description, and merge the 'Key Points' facts about `.source` and symlinks into the Overview to eliminate duplication.
Add explicit verification checkpoints in the 'Making Changes' workflow, e.g., confirm the submodule is on a branch (not detached HEAD) after pulling, and verify symlinks exist after `pnpm install:with-ee` before committing.
Consider moving the Troubleshooting section into a references file to keep SKILL.md focused on the core setup and change workflows.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dominated by lean, executable commands with little concept explanation, but the opening line ("Use this skill when making changes to the enterprise submodule...") duplicates the frontmatter description, and "Key Points" re-states Overview facts ("The `.source` directory contains the actual enterprise source code", symlink descriptions). These minor redundancies keep it at anchor 4 rather than 5. | 4 / 5 |
Actionability | Guidance is fully executable and copy-paste ready: exact commands like `git submodule update --init --recursive`, `git config --global url."https://github.com/".insteadOf "git@github.com:"`, `pnpm install:with-ee`, and `gh pr create --repo novuhq/packages-enterprise --head <branch-name> --base next`, plus a concrete compare-URL fallback for permission failures. This matches anchor 5's complete, specific commands covering common cases. | 5 / 5 |
Workflow Clarity | The "Making Changes in the Submodule" workflow is a clearly sequenced 9-step list with explicit ordering rationale ("Commit in the **submodule first**", "**Merge the submodule PR first**... to avoid broken builds") and a failure fallback, matching anchor 4. It falls short of anchor 5 because there are no explicit validate-then-proceed checkpoints (e.g., verifying the submodule is on a branch rather than detached HEAD after a pull is only a parenthetical note). | 4 / 5 |
Progressive Disclosure | Well-organized sections (Overview, Initial Setup, Pulling Changes, Making Changes, Troubleshooting, Key Points) with all content directly relevant to the workflow and no external references needed. The body is ~84 lines — above the under-50-line simple-skill threshold that would justify a 5 — and sections like Troubleshooting could plausibly live in a reference file, so anchor 4 fits best. | 4 / 5 |
Total | 17 / 20 Passed |