Content
68%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured, highly actionable skill with concrete prefer/avoid examples and a clear workflow. Weaknesses are repeated guidance that could be consolidated into the reference file and a workflow lacking any post-refactor verification step.
Suggestions
Add an explicit verification step to the Workflow (e.g., 'build the target and compare view behavior/previews before finishing') so behavior preservation is checked rather than only stated as a constraint.
Consolidate the subview-extraction guidance repeated in section 3, Workflow step 3, Notes, and Large-view handling into one section, moving extended rationale to references/mv-patterns.md.
Link references/mv-patterns.md from section 2 (Default to MV, not MVVM) where its guidance is most relevant, instead of only mentioning it once in Notes.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is rule-driven without concept padding, but the core "prefer dedicated subview types over computed some View helpers" guidance is repeated across section 3, Workflow step 3, the Notes section, and Large-view handling. Mostly efficient but with duplicated guidance that could be consolidated; more than the minor trimming of anchor 4. | 3 / 5 |
Actionability | Concrete prefer/avoid Swift examples, an explicit top-to-bottom property ordering list, exact property wrappers (@State, @Environment, @Query, @Binding, @StateObject), and a copy-paste init pattern for view models cover the common refactor cases specifically. The undefined helper types (FilterChip, searchService) are standard illustration conventions, not gaps in the guidance. | 5 / 5 |
Workflow Clarity | The 7-step Workflow is clearly sequenced, but no validation checkpoint exists: nothing tells Claude to build, run previews, or verify behavior after refactoring (step 7 is a constraint, not a check). Sequence present with checkpoints missing matches anchor 3; not 4 because no explicit verification step is present. | 3 / 5 |
Progressive Disclosure | Sections are well organized and references/mv-patterns.md is a real, one-level-deep, clearly named reference. Not 5 because the reference is signaled only once in Notes rather than from section 2 whose MV guidance it elaborates, and body section 2 overlaps the reference's content rather than splitting it cleanly. | 4 / 5 |
Total | 15 / 20 Passed |