Content
85%Weight 40%Scale 1-3Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is a high-quality, actionable reference for a complex billing domain, with executable code, exact file references, clear sequenced workflows with validation checkpoints, and well-organized one-level-deep references. Its only weakness is verbosity from cross-section redundancy that could be tightened.
Suggestions
Consolidate the side-effect hook (OnInvoiceIssued / OnPaymentAuthorized / OnPaymentSettled) material, which is currently restated in the Line Engine Lifecycle, App trigger interaction, and Non-Obvious Gotchas sections, into a single canonical location to reduce token cost.
Tighten the Invoice State Machine section by moving the exhaustive per-state listing into a reference file and keeping only the key guards and retry semantics inline, since the body is ~565 lines.
Consider extracting the Tax Handling dual-write write/read flows into `references/` to keep SKILL.md as an overview pointing to detail, consistent with how subscription-sync and testing are already split out.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense with genuinely non-obvious internal OpenMeter knowledge (state machine wiring, tax dual-write, line-engine ownership) that Claude would not already know, so most tokens earn their place. It is not score 3 because the ~565-line body has real redundancy — side-effect hook behavior is restated across the Line Engine Lifecycle section, the App trigger interaction section, and the Non-Obvious Gotchas section — and several passages could be tightened. | 2 / 3 |
Actionability | Provides executable Go snippets (the union-type constructor pattern, the tax code write/read flows), exact file paths and line references (`billing/adapter/stdinvoicelines.go` line 755), and copy-paste-ready checklists ('Adding a new field checklist', 'When adding a new line engine or hook'). This matches fully executable, specific, copy-paste-ready guidance rather than the pseudocode/incomplete score-2 anchor. | 3 / 3 |
Workflow Clarity | Multi-step processes are clearly sequenced with explicit validation checkpoints and feedback loops: the numbered 'Adding a new field checklist', the 5-step 'When adding a new line engine or hook', the customer-locking sequence, and the state machine flow with retryable states (TriggerRetry → DraftValidating) and validation gates (noCriticalValidationErrors). This matches clear sequence with explicit validation and feedback loops, not the score-2 'checkpoints missing or implicit'. | 3 / 3 |
Progressive Disclosure | SKILL.md is a well-sectioned overview with a package map and key-files table, and it offloads detail to two real, clearly-signaled one-level-deep references — 'See `references/subscription-sync.md` for full details' and 'See `references/testing.md` for full test patterns' (both files verified to exist). References are one level deep with easy navigation, matching the well-signaled one-level-deep anchor rather than the score-2 'content that should be separate is inline'. | 3 / 3 |
Total | 11 / 12 Passed |