Content
86%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A strong, highly actionable body: every pattern ships executable BAD/GOOD TypeScript, an explicit tsc --noEmit verification loop, and a clean references table whose six files all exist as cited. The main improvement opportunity is removing duplication between 'When to Apply'/'Use When' and between the Quick Fixes and Anti-Patterns sections, and tightening the implicit workflow into a more explicit sequence.
Suggestions
Merge the 'When to Apply' and 'Use When' sections — their bullets cover the same triggers in different phrasing, and one combined list would cut roughly ten lines without losing information.
Drop or differentiate the 'Type X is not assignable to type Y' quick fix, since its BAD/GOOD pair (getValue() as string vs. typeof-narrowing) duplicates the 'NEVER silence type errors with unchecked assertions' anti-pattern almost verbatim.
Make the apply-then-verify workflow explicit — e.g., a short numbered sequence (find unsafe patterns with the rg command, replace with a guard, re-run tsc --noEmit, fix if narrowing fails) so the validation loop is a sequence rather than guidance embedded in prose.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Lean and competent throughout — no basic-TypeScript tutorials, and the Anti-Patterns use terse BAD/WHY/GOOD blocks. However, the 'When to Apply' and 'Use When' bullet lists largely duplicate each other, and the 'Type X is not assignable' quick fix repeats the same `as string` guard example from the Anti-Patterns section nearly verbatim. This is minor trimmable duplication, matching the 4 anchor ('efficient; minor instances of over-explanation that could be trimmed') rather than 5, and well above 3. | 4 / 5 |
Actionability | Fully executable, copy-paste-ready TypeScript code in every BAD/GOOD pair and quick fix, plus runnable commands: `npx tsc --noEmit` and `rg -n "\bany\b|@ts-ignore| as " src`. The quick fixes target the most common real TypeScript errors ('Object is possibly undefined', incompatible assignment), matching the 5 anchor where specific examples cover the common cases. | 5 / 5 |
Workflow Clarity | An explicit validation checkpoint is present and reinforced twice — 'Verify a narrowing actually narrows by re-running `tsc --noEmit` after the change' and the Quick Commands section — plus a discovery step (the `rg` command for unsafe patterns). But the body presents a catalog of patterns rather than a sequenced apply-then-validate workflow with error-recovery steps. Fits the 4 anchor (clear sequence with most checkpoints, minor gaps); not 3 because validation is explicit rather than missing, not 5 because there is no feedback-loop or checklist structure. | 4 / 5 |
Progressive Disclosure | The body stays an overview and delegates depth to six one-level-deep reference files, all verified to exist exactly as cited, each with a one-line 'Covers' description in a References table, plus out-of-scope pointers routing to sibling skills. This matches the 5 anchor: clear overview, well-signaled references, easy navigation. | 5 / 5 |
Total | 18 / 20 Passed |