CtrlK
BlogDocsLog inGet started
Tessl Logo

tidb-change-instruction-critic

Assess user- or reviewer-proposed TiDB fixes before implementation for intent, correctness, and compatibility.

58

Quality

73%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.agents/skills/tidb-change-instruction-critic/SKILL.md
SKILL.md
Quality
Evals
Security

Quality

Content

78%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

A tight, well-structured instruction-only skill: excellent token efficiency, a clear three-phase workflow with decision gates, and appropriate structure with no unnecessary bundle sprawl. Its weakness is actionability — the rules are specific but entirely abstract, with no concrete TiDB example or worked scenario to anchor them, and validation is delegated rather than demonstrated.

Suggestions

Add one short worked example of evaluating a proposed TiDB fix (e.g., a reviewer suggesting an index change) showing what 'correctness, compatibility, performance' checks concretely look like.

Show a sample 'concise question' so the rule about when to ask versus investigate has a concrete model to follow.

Inline the key regression/validation expectations (or a one-line checklist) instead of delegating entirely to AGENTS.md, so the validate step has an explicit feedback loop.

DimensionReasoningScore

Conciseness

The ~24-line body is lean with zero padding: no explanations of concepts Claude already knows, no boilerplate, and every sentence imposes a concrete decision rule ('do not manufacture options for a straightforward change', 'a fixed options report before every edit is unnecessary'). It matches 'Lean and efficient; assumes Claude's competence; every token earns its place'.

5 / 5

Actionability

The guidance gives specific decision rules (ask only for 'an unresolved requirement, a contract tradeoff the user must decide, or work outside the authorized scope') but remains abstract direction throughout — no concrete example of evaluating a TiDB fix, no illustrative question, no sample compatibility check. It fits 'Some concrete guidance but incomplete... missing key details'; not 4 because an instruction-only skill still needs specific, worked examples of its rules in action.

3 / 5

Workflow Clarity

The three sections sequence the process clearly (Assess the proposed approach → Resolve uncertainty → Implement and validate) with a checkpoint-like gate ('Pause the dependent change while continuing independent authorized work') and a closing validation/reporting step. It falls short of 5 because validation is delegated wholesale to AGENTS.md with no inline feedback loop (validate → fix → re-validate) or concrete validation steps; it is above 3 because the sequence and most checkpoints are explicit.

4 / 5

Progressive Disclosure

The skill is under 50 lines with no bundle files (no references/, scripts/, or assets/ exist) and no content that belongs in a separate file; sections are well-organized under clear headers and the single external pointer (AGENTS.md, a project convention file) is one level deep and clearly signaled. Per the simple-skill guideline, this scores 5.

5 / 5

Total

17

/

20

Passed

Description

53%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description is concise, in third person, and clearly states what the skill does with named evaluation criteria, anchored by the specific TiDB domain. Its main weakness is the complete absence of a 'Use when...' trigger clause with natural user phrases, which caps completeness and limits trigger-term quality.

Suggestions

Append an explicit trigger clause, e.g. 'Use when the user or a reviewer proposes a fix, offers solution options, or leaves review comments with implementation instructions.'

Add natural user-facing trigger terms such as 'review comment', 'proposed fix', 'solution options', and 'before implementing' so the skill surfaces when users phrase requests colloquially.

Consider naming one more concrete action (e.g., 'compare alternative approaches') to lift specificity from one assess-verb toward comprehensive action coverage.

DimensionReasoningScore

Specificity

The description names the domain ("TiDB fixes") and one concrete action ("Assess") with three evaluation criteria ("intent, correctness, and compatibility"), but stops at a single assess-verb rather than listing several specific actions. It matches the anchor 'Names domain and 1-2 concrete actions, but not comprehensive' — not 4, which requires several distinct actions with only minor coverage gaps.

3 / 5

Completeness

The 'what' is clear (assess proposed fixes for intent, correctness, compatibility), but there is no 'Use when...' or equivalent explicit trigger clause; 'when' is only weakly implied by 'before implementation' and 'user- or reviewer-proposed'. The judging guideline explicitly caps completeness at 3 for a missing trigger clause, so it cannot score 4 despite the crisp 'what'.

3 / 5

Trigger Term Quality

Relevant keywords exist ("TiDB", "fixes", "reviewer-proposed", "correctness", "compatibility") but the natural phrases a user would say when needing this skill ("review comment", "code review", "proposed fix", "should I implement this") are absent. It sits between 'One or two generic keywords' and 'Good keyword coverage', with missing common variations keeping it at 3 rather than 4.

3 / 5

Distinctiveness Conflict Risk

'TiDB' pins a clear niche and 'proposed fixes before implementation' distinguishes it from general code-review or implementation skills, but it could still overlap with a generic 'review the proposed change' skill. 'Mostly distinct; minor overlap risk with closely related skills' is the best fit — not 5, since the trigger phrasing is not distinctive enough to fully eliminate overlap.

4 / 5

Total

13

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository
pingcap/tidb
Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.