Content
77%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured triage skill that efficiently guides Claude through a specific debugging workflow with clear sequencing and gate conditions. Its main weakness is that some steps (particularly the failpoint-enabled run) defer to external docs without providing the concrete commands inline, reducing immediate actionability. The output format template is a strong addition that serves as both documentation and a verification checklist.
Suggestions
Include the explicit failpoint-enabled `go test` command inline rather than only referencing `docs/agents/testing-flow.md`, so the skill is self-contained for the most common case.
Add a concrete example of the full bisect loop with a test command, e.g., `git bisect run go test -run TestName -count=1 -tags=intest ./pkg/...` to make the bisect step copy-paste ready.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Every section is lean and purposeful. No unnecessary explanations of what TiDB, failpoints, or git bisect are—assumes Claude already knows these concepts. Each rule is stated directly with only the essential context. | 3 / 3 |
Actionability | Provides concrete commands for git bisect and go test flags, and references a specific doc path for failpoint decisions. However, the failpoint-enabled run command is not shown explicitly (it defers to another doc), and the bisect workflow lacks the full loop (e.g., `git bisect run` with a test command). Some steps remain directional rather than copy-paste ready. | 2 / 3 |
Workflow Clarity | The three rules form a clear, sequenced triage workflow: first rule out failpoint setup, then isolate merge impact, then (and only then) update testdata. Each rule has an explicit gate condition before proceeding, and Rule 3 explicitly prevents premature action. The output format serves as a validation checklist. | 3 / 3 |
Progressive Disclosure | References `docs/agents/testing-flow.md` for failpoint details, which is appropriate one-level-deep disclosure. However, no bundle files are provided to verify the reference exists, and the skill could benefit from clearer signaling of what additional resources are available (e.g., linking to bisect guides or testdata update procedures). | 2 / 3 |
Total | 10 / 12 Passed |