CtrlK
BlogDocsLog inGet started
Tessl Logo
SkillPublic

code-best-practice

PyMC-Marketing coding conventions, preferred implementations, and style guidelines.

Quality

64%

Does it follow best practices?

Run evals on this skill

Adds up to 20 points to the overall score

View guide
SecuritybySnyk

Passed

No findings from the security scan

Fix and improve this skill with Tessl

tessl review fix ./.claude/skills/code-best-practice/SKILL.md

The canonical home for this skill is code-best-practice in pymc-labs/pymc-marketing

SKILL.md
Quality
Evals
Security

Quality

Content

63%Weight 40%Scale 1-5

Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.

The body is a well-organized, largely actionable conventions guide with concrete code examples and a clear pre-PR checklist. Its weaknesses are a handful of explanations of concepts Claude already knows, some illustrative rather than executable snippets, and a monolithic single-file layout with no progressive disclosure into reference files.

Suggestions

Trim explanations of known concepts — the vectorization 'Why' note and PyTensor 'Backend Capabilities'/'Automatic Differentiation' bullets — leaving only the project-specific rule (use pytensor ops; prefer HSGP).

Move deep-dive material (full docstring template, HSGP rationale, class architecture details) into a references/ file and keep SKILL.md as a concise overview with clearly signaled links.

Add a short error-recovery loop to the workflow checklist (e.g., what to do when 'make lint' or mypy fails) and complete the fragmentary code snippets so they are copy-paste ready.

DimensionReasoningScore

Conciseness

The body is mostly bullet points and code, but includes explanations of concepts Claude already knows, e.g., 'Python loops are slow; vectorized operations in C/Fortran backends are orders of magnitude faster' and 'PyTensor graphs can be compiled to C, JAX, or MLX... Essential for gradient-based optimization.' This fits 'Mostly efficient but includes some unnecessary explanation or could be tightened' — above anchor 2 since padding is limited to a few 'Why'/'Backend Capabilities' notes.

3 / 5

Actionability

Concrete, mostly executable guidance throughout: typed signatures with Good/Bad examples, a full NumPy-style docstring template, pm.Data usage, a Prior-based default_model_config, a parametrized pytest example, and exact commands ('make lint', 'pre-commit run mypy --all-files', 'make test'). It stops short of anchor 5 because some snippets are illustrative fragments (e.g., 'def calculate_metric(...) -> ...:', 'x_data = pm.Data(...)' with '...') rather than copy-paste ready.

4 / 5

Workflow Clarity

Sequences are clear: the model class lifecycle is ordered (init -> build_model -> _extract_predictive_variables) with an explicit 'Do not build the PyMC model here' guardrail, and the PR checklist gives concrete commands with lint/test acting as checkpoints. It is below anchor 5 because there is no error-recovery guidance (what to do when mypy or tests fail) and docstring coverage is a directive without a verification step.

4 / 5

Progressive Disclosure

The ~165-line body is well-sectioned but fully inlined with no bundle files at all; detailed material that could live in separate references (the full docstring example, HSGP/pytensor deep-dives, class architecture) is inline. This matches 'Some structure but could be better organized; content that should be separate is inline' rather than anchor 4, and the under-50-line exception does not apply.

3 / 5

Total

14

/

20

Passed

Description

48%Weight 40%Scale 1-5

Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.

The description establishes a specific niche (PyMC-Marketing project conventions) but is a category listing rather than a capability statement: no concrete actions, no 'Use when...' trigger guidance, and no natural trigger synonyms like MMM or CLV. It reads as a document title rather than an invocation description.

Suggestions

Add an explicit trigger clause, e.g., 'Use when writing or reviewing code for the pymc-marketing repository, implementing MMM or CLV models, or defining priors and tests.'

Replace generic category nouns with concrete actions, e.g., 'Apply PyMC-Marketing conventions for typed functions, NumPy-style docstrings, vectorized PyMC/pytensor implementations, Prior-based model configs, and pytest parametrization.'

Include natural trigger synonyms users would actually say — 'pymc-marketing', 'MMM', 'CLV', 'marketing mix modeling', 'contribution guidelines' — to improve keyword coverage.

DimensionReasoningScore

Specificity

The description names the domain ("PyMC-Marketing") and three generic category nouns ("coding conventions, preferred implementations, and style guidelines") but lists no concrete actions, matching the anchor 'Names the domain but actions are minimal or generic'. It falls below anchor 3 because no specific capability (e.g., 'define priors', 'build MMM models', 'write tests') is stated.

2 / 5

Completeness

It has a clear 'what' (conventions, preferred implementations, style guidelines for the project) but no 'Use when...' clause or equivalent trigger guidance, which per the judging guidelines caps completeness at 3. It is above anchor 2 because the 'what' is specific, not vague.

3 / 5

Trigger Term Quality

Terms like "PyMC-Marketing" and "coding conventions" are relevant keywords a contributor might use, but common natural variations are missing — no mention of MMM, CLV, marketing mix modeling, priors, or 'contributing to pymc-marketing'. This fits 'Some relevant keywords but missing common variations or synonyms' rather than anchor 4's 'good keyword coverage'.

3 / 5

Distinctiveness Conflict Risk

The named project "PyMC-Marketing" creates a clear niche with minimal conflict risk against unrelated skills, but the generic phrases 'coding conventions' and 'style guidelines' with no trigger clause leave minor overlap with general coding-style skills, matching 'Mostly distinct; minor overlap risk' rather than anchor 5's 'clear niche with distinct triggers'.

4 / 5

Total

12

/

20

Passed

Validation

100%

Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.

Validation — 16 / 16 Passed

Validation for skill structure

No warnings or errors.

Repository

pymc-labs/pymc-marketing

Path

.claude/skills/code-best-practice/SKILL.md

Reviewed

Table of Contents

Is this your skill?

If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.