test-quality-analysis
Detect test smells, overmocking, flaky tests, and coverage issues. Analyze test effectiveness, maintainability, and reliability. Use when reviewing tests or improving test quality.
79
75%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./plugins/test-quality-analysis/skills/test-quality-analysis/SKILL.mdQuality
Discovery
85%Based on the skill's description, can an agent find and select it at the right time? Clear, specific descriptions lead to better discovery.
This is a well-structured description that clearly communicates specific capabilities and includes an explicit 'Use when' clause. The main weakness is that trigger terms could be broader to capture more natural user phrasings (e.g., 'unit tests', 'test suite', 'brittle tests'). Overall it's a strong description that would help Claude correctly select this skill.
Suggestions
Expand trigger terms to include common user phrasings like 'unit tests', 'test suite', 'brittle tests', 'test refactoring', or 'test code review' to improve matching.
| Dimension | Reasoning | Score |
|---|---|---|
Specificity | Lists multiple specific concrete actions: detect test smells, overmocking, flaky tests, coverage issues, and analyze test effectiveness, maintainability, and reliability. | 3 / 3 |
Completeness | Clearly answers both what ('Detect test smells, overmocking, flaky tests, and coverage issues. Analyze test effectiveness, maintainability, and reliability') and when ('Use when reviewing tests or improving test quality'). | 3 / 3 |
Trigger Term Quality | Includes relevant terms like 'test smells', 'overmocking', 'flaky tests', 'coverage issues', and 'test quality', but misses common user phrasings like 'unit tests', 'test suite', 'test code review', 'brittle tests', or 'test refactoring'. | 2 / 3 |
Distinctiveness Conflict Risk | Focuses on a clear niche of test quality analysis with distinct triggers like 'test smells', 'overmocking', and 'flaky tests' that are unlikely to conflict with general code review or testing skills. | 3 / 3 |
Total | 11 / 12 Passed |
Implementation
64%Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
This is a solid reference skill with excellent concrete examples showing bad vs. good patterns, making it highly actionable. Its main weaknesses are some redundancy (overmocking appears twice), lack of a clear analysis workflow sequence, and the document being somewhat long for an overview file. The checklists are practical but the skill would benefit from a clear step-by-step process for conducting a test quality review.
Suggestions
Add a clear sequential workflow at the top: 'When reviewing tests: 1. Run coverage analysis, 2. Check for test smells, 3. Review assertions, 4. Verify reliability' to guide the analysis process.
Remove the 'Mocking Too Much' anti-pattern section which duplicates the 'Overmocking' test smell section, or consolidate them.
Remove the 'Core Dimensions' bullet list - Claude already knows these concepts and they don't add actionable guidance.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Generally efficient but has some redundancy - the 'Mocking Too Much' anti-pattern repeats the overmocking section almost verbatim. The 'Core Dimensions' bullet list is somewhat generic knowledge Claude already possesses. Some tightening possible. | 2 / 3 |
Actionability | Provides concrete, executable code examples for every smell and anti-pattern with clear bad/good comparisons. Includes runnable CLI commands for coverage tools. The examples are copy-paste ready TypeScript and bash. | 3 / 3 |
Workflow Clarity | The skill is more of a reference/checklist than a multi-step workflow, which is appropriate for its purpose. However, there's no clear sequence for how to actually perform a test quality analysis - no 'start here, then check this, then do that' flow. The checklists help but lack prioritization or ordering guidance. | 2 / 3 |
Progressive Disclosure | The 'See Also' section at the end references related skills, which is good. However, the main content is a fairly long monolithic document that could benefit from splitting detailed examples into separate files. The inline content is well-sectioned but lengthy for a SKILL.md overview. | 2 / 3 |
Total | 9 / 12 Passed |
Validation
90%Checks the skill against the spec for correct structure and formatting. All validation checks must pass before discovery and implementation can be scored.
Validation — 10 / 11 Passed
Validation for skill structure
| Criteria | Description | Result |
|---|---|---|
allowed_tools_field | 'allowed-tools' contains unusual tool name(s) | Warning |
Total | 10 / 11 Passed | |
- Repository
- secondsky/claude-skills
- Commit
88da5ff
- Reviewed
Table of Contents
Is this your skill?
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.