Content
68%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-structured, actionable reference of test-quality guidance with concrete code examples and checklists. Its main gaps are repeated anti-pattern sections and the absence of a sequenced review workflow with validation checkpoints.
Suggestions
Merge the overlapping 'Test Smells' and 'Common Anti-Patterns' sections to remove duplication between Overmocking/Mocking Too Much and Fragile Tests/Testing Implementation Details.
Add a short sequenced review workflow with a validation checkpoint, e.g. 1. run coverage, 2. scan for smells, 3. verify fixes re-pass deterministically.
Make code examples self-contained or note that helper functions are illustrative, so snippets are copy-paste ready.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | Mostly lean with no basic-concept padding, but 'Overmocking' / 'Mocking Too Much' and 'Fragile Tests' / 'Testing Implementation Details' repeat the same guidance, so not every token earns its place. | 4 / 5 |
Actionability | Concrete, executable TypeScript and bash examples with specific detection heuristics ('More than 3-4 mocks', 'Mock only I/O boundaries'), but several snippets reference undefined functions (calculateTotal, registerUser, calculateDistance) so they are not fully copy-paste self-contained. | 4 / 5 |
Workflow Clarity | Provides checklists and tool commands but no sequenced analysis workflow with validation checkpoints — there is no 'run coverage → identify smells → report' process, only loosely ordered lists. | 3 / 5 |
Progressive Disclosure | Well-organized into clearly headed sections with a See Also pointer to sibling skills; no bundle files exist so all content is inline, which is reasonable at this length though some detail could be split into reference files. | 4 / 5 |
Total | 15 / 20 Passed |