Design Doc compliance and security validation with optional auto-fixes
56
47%
Does it follow best practices?
Impact
Pending
No eval scenarios have been run
Passed
No known issues
Optimize this skill with Tessl
npx tessl skill review --optimize ./skills/recipe-front-review/SKILL.mdContext: Post-implementation quality assurance for React/TypeScript frontend
Orchestrator invokes sub-agents and passes structured JSON between them.
Design Doc (uses most recent if omitted): $ARGUMENTS
Think deeply Understand the essence of compliance validation and execute:
# Identify Design Doc
ls docs/design/*.md | grep -v template | tail -1
# Check implementation files
git diff --name-only main...HEADInvoke code-reviewer using Agent tool:
subagent_type: "dev-workflows-frontend:code-reviewer"description: "Code compliance review"prompt: "Design Doc: [path]. Implementation files: [git diff file list]. Review mode: full. Validate Design Doc compliance and return structured JSON report with complianceRate, verdict, acceptanceCriteria, and qualityIssues."Store output as: $STEP_2_OUTPUT
Invoke security-reviewer using Agent tool:
subagent_type: "dev-workflows-frontend:security-reviewer"description: "Security review"prompt: "Design Doc: [path]. Implementation files: [git diff file list]. Review security compliance."Store output as: $STEP_3_OUTPUT
If security-reviewer returned blocked: Stop immediately. Report the blocked finding and escalate to user. Do not proceed to fix steps.
Code compliance criteria (considering project stage):
Security criteria:
approved or approved_with_notes → Passneeds_revision → FailReport both results independently using subagent output fields only (do not add fields that are not in the subagent response):
Code Compliance: [complianceRate from code-reviewer]
Verdict: [verdict from code-reviewer]
Acceptance Criteria:
- [fulfilled] [item]
- [partially_fulfilled] [item]: [gap] — [suggestion]
- [unfulfilled] [item]: [gap] — [suggestion]
Security Review: [status from security-reviewer]
Findings by category:
- [confirmed_risk] [location]: [description] — [rationale]
- [defense_gap] [location]: [description] — [rationale]
- [hardening] [location]: [description] — [rationale]
- [policy] [location]: [description] — [rationale]
Notes: [notes from security-reviewer, if present]
Execute fixes? (y/n):If both pass and user selects n: Skip fix steps, proceed to Final Report.
If user selects y:
Invoke rule-advisor using Agent tool:
subagent_type: "dev-workflows-frontend:rule-advisor"description: "Analyze fix approach"prompt: "Task: Fix review findings. Code issues: $STEP_2_OUTPUT. Security findings: $STEP_3_OUTPUT. Analyze fix essence and select appropriate rules."Register work steps using TaskCreate. Always include: first "Confirm skill constraints", final "Verify skill fidelity". Create task file following task template (see documentation-criteria skill) → docs/plans/tasks/review-fixes-YYYYMMDD.md. Include both code compliance issues and security requiredFixes.
Invoke task-executor-frontend using Agent tool:
subagent_type: "dev-workflows-frontend:task-executor-frontend"description: "Execute review fixes"prompt: "Task file: docs/plans/tasks/review-fixes-YYYYMMDD.md. Apply staged fixes (stops at 5 files)."Invoke quality-fixer-frontend using Agent tool:
subagent_type: "dev-workflows-frontend:quality-fixer-frontend"description: "Quality gate check"prompt: "Confirm quality gate passage for fixed files."Invoke code-reviewer using Agent tool:
subagent_type: "dev-workflows-frontend:code-reviewer"description: "Re-validate compliance"prompt: "Re-validate Design Doc compliance after fixes. Prior issues: $STEP_2_OUTPUT. Design Doc: [path]. Implementation files: [file list]."Invoke security-reviewer using Agent tool:
subagent_type: "dev-workflows-frontend:security-reviewer"description: "Re-validate security"prompt: "Re-validate security after fixes. Prior findings: $STEP_3_OUTPUT. Design Doc: [path]. Implementation files: [file list]."Code Compliance:
Initial: [X]%
Final: [Y]% (if fixes executed)
Security Review:
Initial: [status]
Final: [status] (if fixes executed)
Notes: [notes from approved_with_notes, if any]
Remaining issues:
- [items requiring manual intervention]Scope: Design Doc compliance validation, security review, and auto-fixes.
2e719be
If you maintain this skill, you can claim it as your own. Once claimed, you can manage eval scenarios, bundle related skills, attach documentation or rules, and ensure cross-agent compatibility.