Content
71%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is a dense, well-organized codebase reference with concrete file/class/method pointers and clearly sequenced data flows. Its main weaknesses are a monolithic single-file structure with no progressive disclosure via reference files, and some redundancy across the parallel-apply and transaction-frame sections.
Suggestions
Split the detailed class/method reference ("Key Classes and Data Structures", "Key Utility Modules") into references/ files (e.g. key-classes.md, flows.md), keeping SKILL.md as a concise overview with clearly signaled links.
Consolidate the redundant parallel-apply material spread across "Parallel Apply Infrastructure", "Parallel Apply Architecture", and "Threading Model" into a single section, and trim the overlap between "Key Files" and "Key Classes".
Add a short task-oriented index mapping common goals ("add a new operation", "trace a fee refund", "understand offer crossing") to the relevant files and classes to further boost actionability.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense and factual with zero concept padding — it never explains what XDR, DEX, or a signature is, and assumes Claude's competence throughout. It falls short of 5 due to redundancy: TransactionFrame and the parallel-apply infrastructure are each described across multiple sections ("Key Files", "Key Classes", "Parallel Apply Architecture", "Threading Model"). | 4 / 5 |
Actionability | Concrete navigation pointers abound — exact file names ("TransactionFrame.h/.cpp"), method names ("commonValid", "processFeeSeqNum"), and call chains ("convertWithOffersAndPools() which iterates matching offers" → "crossOfferV10() → exchangeV10()"). Not 5 because there is no executable code or commands; for a codebase-reference skill the guidance is nonetheless specific and usable. | 4 / 5 |
Workflow Clarity | Data flows are explicitly numbered and sequenced ("1. Deserialization ... 5. Parallel Apply"; the parallel-apply architecture steps 1-7) and show where validation occurs in the pipeline ("checkValid() → ... commonValid() → ... checkAllSignaturesUsed()"). Not 5 because these document the code's behavior rather than giving Claude an operative workflow with feedback loops; not 3 because sequencing is complete and checkpoints are shown. | 4 / 5 |
Progressive Disclosure | The entire ~290-line reference is inline in SKILL.md with no bundle files — the detailed class/method reference (200+ lines of it) that could live in separate reference files is fully inlined. It is not 2 because the internal structure is good with clear section headers and hierarchies; it is not 4 because nothing is split out into or signaled from separate files. | 3 / 5 |
Total | 15 / 20 Passed |