Content
71%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The body is a strong, terse, opinionated ruleset: nearly every line is an executable instruction with concrete commands, paths, and thresholds, and the coverage workflow is well sequenced with validation gates. Its main weaknesses are content that belongs in reference files (package rules, allowlists) being inlined in SKILL.md, and verbatim duplication between the seam-selection, core-package, and quick-reference sections.
Suggestions
Move the package-specific rules (`autoformat`, `markdown`, `ai/streaming`, `slate`, `docx`) and the `createPlateEditor`/`__tests__` allowlists into a one-level-deep reference file (e.g. references/package-rules.md) and keep SKILL.md as the overview plus core rules.
De-duplicate the `createSlateEditor` bullet list (Seam Selection vs the `core` section) and the two-lanes/lcov/package-locality rules restated in 'Quick Reference' so each rule is stated once.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body is dense, imperative, and assumes competence — no basic-concept explanations — with concrete thresholds like '60ms/test or 120ms/file' and exact paths ('tooling/config/test-suites.mjs'). It falls short of a 5 because of genuine duplication: the `createSlateEditor` bullet list appears verbatim in both 'Seam Selection' and the `core` package section, and the 'Quick Reference' section restates rules already stated above (two lanes, lcov over Bun summary, package-locality). | 4 / 5 |
Actionability | Guidance is concrete and executable: exact commands ('pnpm test:slowest -- --top 25 --rerun-each 3', 'bun run test:profile'), exact file-naming conventions ('*.spec.ts[x]' vs '*.slow.ts[x]'), exact paths, and numeric coverage-pass thresholds ('>= 6', then '>= 5'). It is not a 5 because some instructions are named but never shown — e.g. 'table-drive repeated node-type cases', 'extract one editor helper', and the hyperscript fixture style have no example snippet, leaving the reader to invent the pattern. | 4 / 5 |
Workflow Clarity | The coverage workflow is explicitly sequenced with passes (>= 6 pass, rerun fresh lcov, >= 5 pass, architecture-safety pass, then explicit stop criteria for wrappers/crumbs/sludge) and includes validation checkpoints and feedback loops (profile -> rename to *.slow.ts -> pnpm test:slowest hard gate). It falls short of a 5 because the workflow is distributed across four sections ('Testing Goal', 'Coverage Strategy', 'Cleanup Heuristics', 'Quick Reference') rather than presented as one coherent ordered procedure. | 4 / 5 |
Progressive Disclosure | Sectioning is clean and there are no dangling or nested references, but the entire rulebook — including package-specific rules (`autoformat`, `markdown`, `slate`, `docx`), allowlists, and the upstream slate-react mining list — lives inline in one 250-line SKILL.md with no reference files at all. That matches 'content that should be separate is inline'; it is above a 2 only because the sections are well-organized and the in-body file paths (e.g. 'tooling/config/bunTestSetup.ts', 'apps/www/src/__tests__/package-integration') are real and clearly signaled. | 3 / 5 |
Total | 15 / 20 Passed |