Content
86%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
A well-crafted, terse policy/workflow skill body: lean prose, an ordered replacement taxonomy, concrete anti-patterns, and correctly factored-out reference files. The remaining gaps are a concrete example lint rule for enforcement and an explicit error-recovery loop after the verification gates.
Suggestions
Add a minimal, copy-paste-ready eslint rule config (e.g., no-restricted-imports/no-restricted-syntax patterns for useEffect) to the Enforcement section or to references/replacements.md, since 'extend the repository's existing linter' currently leaves the rule shape to inference.
Add an explicit feedback loop after step 4: what to do when lint, type, or test gates fail (fix, re-run, and only report completion once gates pass).
Make the review-path protocol's verification concrete — e.g., how a finding should be demonstrated (touched lines, effect classification) so a review produces consistent, checkable findings.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The body never explains React or effect basics Claude already knows; it is dense directive prose ("Components do not call it; a reviewed, domain-specific hook for a real external system may") with every token earning its place. Matches the lean-and-efficient top anchor. | 5 / 5 |
Actionability | Concrete guidance throughout: a 7-item ordered replacement preference list, named anti-patterns with exact signatures ("useUpdateEffect(fn, deps)", "useAsyncEffect(fn, deps)"), and a specific lint surface (reject named imports and React.useEffect calls, allow only named reviewed hook files). Below 5 because the enforcement section lacks a concrete example lint rule/config, and directives like "state the external synchronization contract" are abstract. | 4 / 5 |
Workflow Clarity | The 4-step workflow (find → classify/replace → preserve constraints → run gates) is clearly sequenced with a named validation checkpoint ("Run lint, type, and test gates plus the smallest real UI or hook check"), and review-mode behavior is separately specified. Not 5 because there is no explicit fix-and-re-run error-recovery loop after the gates, and the review path's findings protocol has no verification step. | 4 / 5 |
Progressive Disclosure | The ~80-line SKILL.md is an overview that correctly splits non-obvious detail into references/replacements.md (52 well-sectioned lines) and references/upstream.md, both real files linked one level deep at point of use ("[Replacements](references/replacements.md) covers the non-obvious cases"). Structure and navigation match the top anchor. | 5 / 5 |
Total | 18 / 20 Passed |