Content
50%Weight 40%Scale 1-5Reviews the quality of instructions and guidance provided to agents. Good implementation is clear, handles edge cases, and produces reliable results.
The skill body is highly actionable, with concrete executable configuration, fixtures, factories, and test examples covering the full Django testing stack. However, it is noticeably verbose for a SKILL.md — inlining ~730 lines of largely standard patterns with duplication and no reference files — and its TDD workflow lacks executable validation checkpoints.
Suggestions
Move the standard example suites (model, view, serializer, and API tests) into references/ files, keeping SKILL.md as a lean overview of project-specific conventions (pytest.ini, test settings, conftest fixtures, factory patterns).
Remove duplication: define api_client only in conftest.py and drop the duplicate fixture inside TestProductAPI; merge the two inconsistent tests/test_models.py blocks.
Make the TDD cycle executable: show the actual commands (e.g. "pytest tests/test_models.py -x" to confirm RED) with a checkpoint before the GREEN step, and fix undefined fixtures (TagFactory, category, order) so examples run as written.
| Dimension | Reasoning | Score |
|---|---|---|
Conciseness | The ~730-line body inlines complete example suites for standard model, view, serializer, and API testing that largely restate patterns Claude already knows, with duplication such as two different "tests/test_models.py" blocks (lines 214 and 242) and an api_client fixture defined both in conftest.py and again inside TestProductAPI. This matches "noticeably verbose; several unnecessary sections"; it avoids a 1 because prose is minimal and nearly all content is code rather than padded explanation. | 2 / 5 |
Actionability | Nearly all guidance is executable code: a complete pytest.ini, test settings module, conftest fixtures, factory definitions, and runnable commands ("pytest --cov=apps --cov-report=html --cov-report=term-missing"). Minor gaps keep it from a 5: TagFactory, a category fixture, and an order fixture are used but never defined, and "authenticated_api_client.user" would not exist on the APIClient the fixture returns. | 4 / 5 |
Workflow Clarity | The Red-Green-Refactor cycle is sequenced, but its GREEN and REFACTOR steps are placeholder comments ("# Create User model or factory"), and no command or checkpoint verifies the RED failure before implementing. Sequence present with implicit checkpoints matches anchor 3; it is not a 2 because setup ordering (pytest config → settings → conftest → factories) is coherent and sections are logically ordered, and not a 4 because no explicit run-and-validate loop exists. | 3 / 5 |
Progressive Disclosure | No bundle files exist (references/, scripts/, assets/ are absent), so all content lives in SKILL.md. Section headers are clear and aid navigation, but bulk material — factory definitions, the full API test suite, coverage configuration — that belongs in one-level-deep reference files is inlined, matching "content that should be separate is inline" at anchor 3 rather than the header-less monolith of anchor 2. | 3 / 5 |
Total | 12 / 20 Passed |